Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from opencensus library: extension/healthcheck #33469

Closed
Tracked by #29867
codeboten opened this issue Jun 10, 2024 · 0 comments · Fixed by #33470
Closed
Tracked by #29867

Migrate from opencensus library: extension/healthcheck #33469

codeboten opened this issue Jun 10, 2024 · 0 comments · Fixed by #33470
Assignees
Labels
never stale Issues marked with this label will be never staled and automatically removed

Comments

@codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten changed the title extension/healthcheck Migrate from opencensus library: extension/healthcheck Jun 10, 2024
@codeboten codeboten self-assigned this Jun 10, 2024
codeboten added a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Jun 10, 2024
This PR removes the dependency on opencensus by removing the code that sets up a
view to trigger healthcheck status changes. This functionality does not work as
documented in the README: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check

I'm proposing to remove the code that brings an unnecessary dependency for
functionality that isn't working.

Fixes open-telemetry#33469

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten added the never stale Issues marked with this label will be never staled and automatically removed label Jun 11, 2024
codeboten added a commit that referenced this issue Jun 11, 2024
This PR removes the dependency on opencensus by removing the code that
sets up a view to trigger healthcheck status changes. This functionality
does not work as documented in the README:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/healthcheckextension#health-check

I'm proposing to remove the code that brings an unnecessary dependency
for functionality that isn't working.

Fixes #33469

As discussed previously
#29782,
an improved functionality will be implemented in the v2 healthcheck
extension

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never stale Issues marked with this label will be never staled and automatically removed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant