swallowed exception in Operator.Process

[zeitlinger]

Component(s)

pkg/stanza, pkg/stanza/fileconsumer

What happened?

Description

Some of the usages of

opentelemetry-collector-contrib/pkg/stanza/operator/operator.go

Line 40 in d78d7bb

Process(context.Context, *entry.Entry) error

don't check for the error, which can lead to silent errors

Steps to Reproduce

Real config

      filelog/fraud-detection-raw:
        include:
          - /var/log/pods/*/*/*.log      
        operators:
        - id: container-parser
          type: container

Why?

• include_file_path: true is missing - but is required unless you set add_metadata_from_filepath: false
• exception:

  opentelemetry-collector-contrib/pkg/stanza/operator/parser/container/parser.go

  Line 294 in 6395ff8

  return fmt.Errorf("type '%T' cannot be parsed as log path field", logPath)

Test

remove this line:

opentelemetry-collector-contrib/pkg/stanza/operator/parser/container/parser_test.go

Line 246 in 6395ff8

"log.file.path": "/var/log/pods/some_kube-scheduler-kind-control-plane_49cc7c1fd3702c40b2686ea7486091d3/kube-scheduler44/1.log",

Expected Result

error is reported to user

Actual Result

error is silent - you just don't get log messages

Collector version

0.103.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions]

Pinging code owners:

• pkg/stanza: @djaglowski
• pkg/stanza/fileconsumer: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[djaglowski]

Thanks for reporting @zeitlinger. I agree this is a problem. Do you want to make a PR for this?

[zeitlinger]

Thanks for reporting @zeitlinger. I agree this is a problem. Do you want to make a PR for this?

Created #33847