k8sclusterreceiver: Standardize metric names #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace "/" with "." in metric names - daemon_set -> daemonset, stateful_set -> statefulset, replica_set -> replicaset
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 88.94% 89.10% +0.16%
==========================================
Files 258 258
Lines 12330 12330
==========================================
+ Hits 10967 10987 +20
+ Misses 1011 990 -21
- Partials 352 353 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Thanks a lot for taking care of this! |
dmitryax
reviewed
Sep 24, 2020
Will open a separate PR for the exporter. |
dmitryax
approved these changes
Sep 25, 2020
tigrannajaryan
pushed a commit
that referenced
this pull request
Sep 28, 2020
Update translations for `k8s_cluster` receiver metrics. Follow-up to #1119.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
* Add InstrumentationLibrary info to Zipkin/Jaeger exporters This addresses spec issues open-telemetry/opentelemetry-specification#800 open-telemetry/opentelemetry-specification#801 and opentelemetry-go issues open-telemetry/opentelemetry-go#1086 open-telemetry/opentelemetry-go#1087 * Reflect change in CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing: Updated tests
Documentation: Updated references in README.