Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[resourcedetectionprocessor] Add EC2 hostname attribute #1324

Merged
merged 4 commits into from
Oct 26, 2020
Merged

[resourcedetectionprocessor] Add EC2 hostname attribute #1324

merged 4 commits into from
Oct 26, 2020

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 20, 2020 •
edited
Loading

Description:

Adds EC2 fully qualified host name to the information gathered by the EC2 resource detector.
The information I query from EC2 metadata is documented here as

The private IPv4 DNS hostname of the instance. In cases where multiple network interfaces are present, this refers to the eth0 device (the device for which the device number is 0).

I associate this information to the host.name key, defined in the spec as

Name of the host. On Unix systems, it may contain what the hostname command returns, or the fully qualified hostname, or another name specified by the user.

Link to tracking Issue: n/a

Testing: I amended the unit tests to include this new function. I tested on an EC2 instance that the information was retrieved correctly.

Documentation: Added the new resource to the README list.

@mx-psi mx-psi marked this pull request as ready for review October 20, 2020 15:14
jrcamp
jrcamp reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@jrcamp jrcamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change requested with error handling. Thanks!

processor/resourcedetectionprocessor/internal/aws/ec2/ec2.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from a team October 21, 2020 07:59
@tigrannajaryan tigrannajaryan self-assigned this Oct 21, 2020
@mx-psi mx-psi requested a review from jrcamp October 22, 2020 12:50
@mx-psi
Copy link
Member Author

mx-psi commented Oct 26, 2020

@jrcamp @tigrannajaryan, anything else to address on this PR? Can we get it merged if not?

@tigrannajaryan tigrannajaryan merged commit 43e5b59 into open-telemetry:master Oct 26, 2020
@mx-psi mx-psi mentioned this pull request Oct 27, 2020
Closed
6 tasks
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@dmitryax
Bump CPU limit for a TraceNoBackend10kSPS/JaegerGRPC load test (#1324)
1cbae96 
TraceNoBackend10kSPS/JaegerGRPC/NoMemoryLimit load test is flaky and often goes over 60%. Looking at the history wasn't able to identify a if something might cause a regression.
@mx-psi mx-psi mentioned this pull request May 5, 2021
Closed
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@krnr
asyncpg: Use only the first word from query as a span name (#1324)
f349e38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrcamp jrcamp jrcamp approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@james-bebbington james-bebbington Awaiting requested review from james-bebbington

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mx-psi @jrcamp @tigrannajaryan