Use same docker image in CircleCI for all jobs #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
pjanotti
approved these changes
Mar 30, 2020
tigrannajaryan
approved these changes
Mar 30, 2020
Also attach to entire workspace instead of current directory.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
Fixes #445, #158 This PR addresses some Jaeger receiver config cleanup as well as makes some breaking changes to the way the config is handled. See below for details. **Fixes/Updates** - Disabled flag is respected per protocol - Unspecified protocols will no longer be started - Empty protocol configs can now be specified to start the protocol with defaults. e.g. ``` jaeger: protocols: grpc: ``` - Updated readmes - Naming and behavior of per protocol Addr/Enabled functions in `trace_reciever.go` has been standardized. - Added thrift tchannel test to meet code coverage **Breaking Change** Changed the way an empty `jaeger:` config is handled. An empty/default config does not start any jaeger protocols. Previously it started all three collector protocols. This is a consequence of not starting unspecified protocols.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.21.0 to 0.21.1. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.21.0...v0.21.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make sure all jobs use the same docker image. We moved to
cimg/go:1.14last week but looks like we missed one place.