Add support for resource mapping in the Stackdriver exporter config #163
Conversation
nilebox
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
There was a problem hiding this comment.
minimum label check functionality is missing. For example, for a specific resource_type stackdriver expects that certain labels be present. Even if one of the label is not present then entire time-series request is rejected.
So, either all required mappings are mandatory OR create additional parameter for each label whether it is mandatory or not. If it is mandatory and the label is missing then it defaults to defaultMapper.
Made labels required by default, with extra |
| Labels: map[string]string{ | ||
| // Labels passed through with no changes | ||
| "source.label1": "value1", | ||
| "project_id": "123", |
There was a problem hiding this comment.
For a moment I was wondering why project_id got converted even though the other mandatory label is missing. But the project_id is converted by default implementation. Perhaps add this info in the comment.
There was a problem hiding this comment.
Added comments to clarify.
| type LabelMapping struct { | ||
| SourceKey string `mapstructure:"source_key"` | ||
| TargetKey string `mapstructure:"target_key"` | ||
| Optional bool `mapstructure:"optional"` |
There was a problem hiding this comment.
Can you document the semantics of this parameter? When would one set it to true?
There was a problem hiding this comment.
It just signals that we can proceed with transformation when a particular label with a given source_key is missing.
I will add a comment.
The original PR was made before the change in model of factory registration. This change moves it to the current factory registration.
* sdk/trace: Test the Sampling Probability Closes #163 * Add tests for when the parent is sampled.
Bumps [go.opentelemetry.io/collector](https://github.com/open-telemetry/opentelemetry-collector) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-collector@v0.26.0...v0.27.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antoine Toulme <antoine@lunar-ocean.com>
Description:
Adding a feature - declarative config for mapping OpenCensus resources to Stackdriver resources.
Testing: Unit tests
Documentation: -