Use k8s.pod.ip to record resource IP instead of just ip
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
rghetia,
songy23 and
tigrannajaryan
as code owners
processor/k8sprocessor/processor.go
Outdated
| } | ||
|
|
||
| // Jaeger client libs tag the process with the process/resource IP and | ||
| // jaeger to OC translator maps jaeger process to OC node. | ||
| // TODO: Should jaeger translator map jaeger process to OC resource instead? | ||
| if podIP == "" && td.SourceFormat == sourceFormatJaeger { | ||
| if td.Node != nil { | ||
| podIP = td.Node.Attributes[ipLabelName] | ||
| podIP = td.Node.Attributes[clientIPLabelName] |
There was a problem hiding this comment.
Is it possible that k8sIPLabelName exists in td.Node.Attributes at this point? Do we need to check for it as well?
There was a problem hiding this comment.
Unlikely but possible. I think it can happen if Otel agent detects and adds the IP to resource but then exports to Otel collector in Jaeger or SAPM instead of OTLP/OC. I don't see any downsides to covering for this case. Will update.
Since the k8s processor prefixes all labels with `k8s.*.`, adding the same prefix to the IP label. We'll still continue to look for the `ip` label on resource/node when we can't find the IP by other means but will only write the IP back to `k8s.pod.ip`.
|
Thanks @owais ! |
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
Since the k8s processor prefixes all labels with `k8s.*.`, adding the same prefix to the IP label. We'll still continue to look for the `ip` label on resource/node when we can't find the IP by other means but will only write the IP back to `k8s.pod.ip`.
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
* Use batcher and queued-retry on perf tests The typical usage is expected to have both the batcher and the queued-retry so changing the perf tests to use them. Also adding a test with addattributesprocessor that requires a differenc configuration file. * Merge corrections * Fix configuration, do not batch for now * Adjust memory for TestNoBackend10kSPS
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
bjrara
pushed a commit
to bjrara/opentelemetry-collector-contrib
that referenced
this pull request
Apr 3, 2024
open-telemetry#183) * [receivers/awscontainerinsightsreceiver] Add podresourcesstore in awscontainerinsightreceiver (open-telemetry#167) ref : amazon-contributing#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Use
k8s.pod.ipto record resource IP instead of justipSince the k8s processor prefixes all labels with
k8s.*., adding thesame prefix to the IP label. We'll still continue to look for the
iplabel on resource/node when we can't find the IP by other means but will
only write the IP back to
k8s.pod.ip.Testing: Tested locally and updated unit tests