Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span attributes as honeycomb event fields. #271

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add span attributes as honeycomb event fields. #271

merged 1 commit into from
Jun 2, 2020

Conversation

paulosman
Copy link
Member

Fixing a regression introduced in the recent refactoring of the honeycomb exporter. Attributes were supported on span links and message events, but not on the span itself.

Fixing a regression introduced in the recent refactoring of the
honeycomb exporter. Attributes were supported on span links and message
events, but not on the span itself.
@paulosman paulosman requested a review from a team June 2, 2020 15:17
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #271 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   78.82%   78.89%   +0.06%     
==========================================
  Files         159      159              
  Lines        8053     8056       +3     
==========================================
+ Hits         6348     6356       +8     
+ Misses       1349     1347       -2     
+ Partials      356      353       -3     
Impacted Files Coverage Δ
exporter/honeycombexporter/honeycomb.go 85.00% <100.00%> (+0.32%) ⬆️
exporter/signalfxexporter/dimensions/requests.go 93.10% <0.00%> (+8.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e09f72...146e65a. Read the comment docs.

@bogdandrutu bogdandrutu self-requested a review June 2, 2020 20:50
@bogdandrutu bogdandrutu merged commit 2c59911 into open-telemetry:master Jun 2, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
Fixing a regression introduced in the recent refactoring of the
honeycomb exporter. Attributes were supported on span links and message
events, but not on the span itself.
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
* Update DESIGN doc

- Added a section describing the pipeline and its components.
- Deleted paragraphs which are no longer relevant.

TODO: update a couple diagrams which still show "OpenCensus"

* PR fixes.

* More PR fixes
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants