Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Refactor WaitGroup into separate fields for traces and metrics exporter #33291

Merged
merged 4 commits into from
May 30, 2024

Conversation

liustanley
Copy link
Contributor

@liustanley liustanley commented May 29, 2024

Description:

TraceAgent is only called in the traces exporter and consumeStatsPayload is only called in the metrics exporter, so I think using the same wg field was causing conflicts with both exporters in use at the same time. This PR splits wg into separate fields for each use case.

This PR also removes wg.Wait on the logs exporter since that wasn't applicable in the first place.

Link to tracking Issue:

Testing:

Documentation:

@github-actions github-actions bot added the exporter/datadog Datadog components label May 29, 2024
@liustanley liustanley marked this pull request as ready for review May 29, 2024 17:02
@liustanley liustanley requested a review from a team May 29, 2024 17:02
@songy23 songy23 added the Run ARM Enable running ARM tests on a PR label May 29, 2024
@songy23 songy23 removed the Run ARM Enable running ARM tests on a PR label May 29, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changelog too as a bug fix

@liustanley liustanley requested a review from songy23 May 29, 2024 20:49
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label May 30, 2024
@codeboten codeboten merged commit 9a0c38c into open-telemetry:main May 30, 2024
166 of 169 checks passed
@github-actions github-actions bot added this to the next release milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants