[processor/probabilisticsampling] use mdatagen for metrics #33874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/probabilisticsampler
jpkrohling
reviewed
Jul 3, 2024
|
|
||
| telemetry: | ||
| metrics: | ||
| count_traces_sampled: |
There was a problem hiding this comment.
I think this needs the otelcol_processor prefix. Can you confirm with the metrics we have today?
There was a problem hiding this comment.
Metrics before the change:
# HELP otelcol_processor_probabilistic_sampler_count_traces_sampled Count of traces that were sampled or not
# TYPE otelcol_processor_probabilistic_sampler_count_traces_sampled counter
otelcol_processor_probabilistic_sampler_count_traces_sampled{policy="missing_randomness",sampled="false",service_instance_id="f1a27d2b-5019-44b7-8dbb-b35b6f852c8c",service_name="otelcontribcol",service_version="0.104.0-dev"} 2
otelcol_processor_probabilistic_sampler_count_traces_sampled{policy="trace_id_hash",sampled="true",service_instance_id="f1a27d2b-5019-44b7-8dbb-b35b6f852c8c",service_name="otelcontribcol",service_version="0.104.0-dev"} 2
After the change:
# HELP otelcol_processor_probabilistic_sampler_count_logs_sampled Count of logs that were sampled or not
# TYPE otelcol_processor_probabilistic_sampler_count_logs_sampled counter
otelcol_processor_probabilistic_sampler_count_logs_sampled{policy="missing_randomness",sampled="false",service_instance_id="4d31ffcc-1341-4ae0-84be-5d77592319f9",service_name="otelcontribcol",service_version="0.104.0-dev"} 1
# HELP otelcol_processor_probabilistic_sampler_count_traces_sampled Count of traces that were sampled or not
# TYPE otelcol_processor_probabilistic_sampler_count_traces_sampled counter
otelcol_processor_probabilistic_sampler_count_traces_sampled{policy="trace_id_hash",sampled="true",service_instance_id="4d31ffcc-1341-4ae0-84be-5d77592319f9",service_name="otelcontribcol",service_version="0.104.0-dev"} 2
There was a problem hiding this comment.
Note the change in the name of the logs vs traces sampled counter is a bugfix
Fixes open-telemetry#33465 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/mdatagen-probabilistic-processor
branch
from
b73a52f
to
58894ef
Compare
jpkrohling
approved these changes
Jul 4, 2024
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33465