AWS X-Ray exporter: Only convert SQL information for SQL databases. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
Jul 6, 2020
anuraaga
changed the title
|
@dmitryax Sure done |
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 83.92% 83.90% -0.03%
==========================================
Files 178 178
Lines 9520 9520
==========================================
- Hits 7990 7988 -2
- Misses 1202 1203 +1
- Partials 328 329 +1
Continue to review full report at Codecov.
|
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
Shutdown() method is added so that we can implement proper pipeline flushing during collector shutdown. This will be done in a future PR.
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
…Span (#379) Signed-off-by: vineeth <vineethpothulapati@outlook.com>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, we fill in the X-Ray
sqlfield for any database. However, it's only meant for SQL databases - notably, if it's filled for a redis database, X-Ray displays it incorrectly as aDatabase::SQL.