Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keeping timeseries and points in order after aggregation in metrics transform processor #663

Merged
merged 4 commits into from
Aug 7, 2020

Conversation

JingboWangGoogle
Copy link
Contributor

Description: This update to the metrics transform processor would keep the timeseries and points ordered by timestamp

Link to tracking Issue: #332

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #663 into master will increase coverage by 0.00%.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         196      196           
  Lines       10754    10765   +11     
=======================================
+ Hits         9282     9292   +10     
- Misses       1136     1137    +1     
  Partials      336      336           
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 86.15% <72.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cstransformprocessor/operation_aggregate_labels.go 90.32% <0.00%> (-9.68%) ⬇️
...metricstransformprocessor/datapoint_aggregation.go 100.00% <100.00%> (ø)
...stransformprocessor/metrics_transform_processor.go 100.00% <100.00%> (ø)
...sformprocessor/operation_aggregate_label_values.go 100.00% <100.00%> (ø)
receiver/carbonreceiver/transport/tcp_server.go 67.61% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d45a5...5fed9ab. Read the comment docs.

@JingboWangGoogle JingboWangGoogle marked this pull request as ready for review August 7, 2020 05:27
@JingboWangGoogle JingboWangGoogle requested a review from a team August 7, 2020 05:27
@bogdandrutu bogdandrutu merged commit e4ff1b8 into open-telemetry:master Aug 7, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
* Botocore: Fix span inject for lambda invoke

* for lambda invoke span injection happend to early which resulted in the botocore
  span being injected instead of the actual botocore span

* changelog

Co-authored-by: alrex <aboten@lightstep.com>
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants