Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfx exporter: rename working-set and page-fault metrics #679

Merged
merged 1 commit into from
Aug 11, 2020
Merged

sfx exporter: rename working-set and page-fault metrics #679

merged 1 commit into from
Aug 11, 2020

Conversation

pmcollins
Copy link
Member

Description: Add renames in SFx exporter for the kubeletstats receiver's working-set and page-fault metrics.

Testing: Unit tests added to verify presence of renamed metrics.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   86.80%   86.80%           
=======================================
  Files         197      197           
  Lines       10749    10749           
=======================================
  Hits         9331     9331           
  Misses       1088     1088           
  Partials      330      330           
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 86.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2a04c...3ac0d60. Read the comment docs.

@pmcollins pmcollins marked this pull request as ready for review August 10, 2020 16:19
@pmcollins pmcollins requested a review from a team August 10, 2020 16:19
@bogdandrutu bogdandrutu merged commit dba5e02 into open-telemetry:master Aug 11, 2020
@pmcollins pmcollins deleted the sfx-mem-translations branch August 21, 2020 16:02
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Add a key benchmark, optimize SDK SetAttribute

* Use reflect in key.Infer

* Move to separate benchmark file; remove pointer test; remove dead comment

* Run go mod tidy

* Add license header

* Use the reflect scalar accessors

Co-authored-by: Liz Fong-Jones <lizf@honeycomb.io>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
* botocore hooks

* a single hook for all aws services

* fix test

* rename get_item_attributes variable to put_item_attributes

* rename tests

* delete redundant line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants