Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/otlp] Promote component.UseLocalHostAsDefaultHost to beta #10352

Merged
merged 7 commits into from
Jun 27, 2024
Merged

[receiver/otlp] Promote component.UseLocalHostAsDefaultHost to beta #10352

merged 7 commits into from
Jun 27, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 6, 2024

Description

Promotes component.UseLocalHostAsDefaultHost feature gate to beta.

Link to tracking issue

Updates #8510

@mx-psi mx-psi force-pushed the mx-psi/enable-component-localhost-fgh branch from 3f8d0b0 to 9b0456f Compare June 6, 2024 13:17
@yurishkuro
Copy link
Member

+1

atoulme
atoulme approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mx-psi mx-psi force-pushed the mx-psi/enable-component-localhost-fgh branch from 9421dc1 to 25eac70 Compare June 18, 2024 13:11
@mx-psi mx-psi force-pushed the mx-psi/enable-component-localhost-fgh branch from 25eac70 to ccc5cd9 Compare June 18, 2024 15:19
@mx-psi mx-psi marked this pull request as ready for review June 18, 2024 15:19
@mx-psi mx-psi requested review from a team and djaglowski June 18, 2024 15:19
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.40%. Comparing base (227fb82) to head (7f86347).

❗ Current head 7f86347 differs from pull request most recent head da566f0

Please upload reports for the commit da566f0 to get more accurate results.

Files Patch % Lines
internal/localhostgate/featuregate.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10352   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         393      393           
  Lines       18584    18584           
=======================================
  Hits        17173    17173           
  Misses       1056     1056           
  Partials      355      355

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mx-psi
mx-psi commented Jun 19, 2024
View reviewed changes
otelcol/testdata/otel-log-to-file.yaml
level: warn
level: info
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make the Windows service test pass. Before this change, we had the warning from confighttp and configgrpc, but after it there are no logs at warn level with this config, which makes the assertion that the logs were stored in a file fail

@mx-psi mx-psi mentioned this pull request Jun 20, 2024
Merged
@mx-psi
Copy link
Member Author

mx-psi commented Jun 20, 2024

Please also take a look at the contrib counterpart, open-telemetry/opentelemetry-collector-contrib/pull/33658, cc @TylerHelmuth

@mx-psi mx-psi mentioned this pull request Jun 27, 2024
Merged
1 task
@mx-psi mx-psi merged commit fead8fc into open-telemetry:main Jun 27, 2024
48 checks passed
@mx-psi mx-psi deleted the mx-psi/enable-component-localhost-fgh branch June 27, 2024 16:54
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jun 27, 2024
@mx-psi
[all] Promote component.UseLocalHostAsDefaultHost feature gate to b…
968d4b8 
…eta (#33658)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Counterpart to open-telemetry/opentelemetry-collector/pull/10352.

**Link to tracking Issue:**
open-telemetry/opentelemetry-collector/issues/8510
@github-actions github-actions bot added this to the next release milestone Jun 27, 2024
This was referenced Jul 3, 2024
Closed
Merged
codeboten pushed a commit that referenced this pull request Jul 3, 2024
@mx-psi @songy23
[internal/localhostgate] Correctly log message about local host gate (#…
8d3c19d 
…10529)

Fixes log intended to be logged when the feature gate is enabled, not
disabled.

#### Link to tracking issue

Relates to #8510, updates #10352

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@mx-psi mx-psi mentioned this pull request Jul 5, 2024
Merged
codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jul 5, 2024
@mx-psi
[chore] Add explicit endpoint on examples (#33930)
59170a3 
Following open-telemetry/opentelemetry-collector/pull/10352 we need to
update examples to use `0.0.0.0`.

Relates to open-telemetry/opentelemetry-collector/issues/8510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@djaglowski djaglowski djaglowski approved these changes

@songy23 songy23 songy23 approved these changes

@evan-bradley evan-bradley evan-bradley approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.104.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mx-psi @yurishkuro @atoulme @djaglowski @songy23 @evan-bradley @TylerHelmuth