Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make otelhttp produce old, new and duplicate Client Trace Attributes #5332

Closed
3 tasks done
MadVikingGod opened this issue Mar 28, 2024 · 3 comments
Closed
3 tasks done

Make otelhttp produce old, new and duplicate Client Trace Attributes #5332

MadVikingGod opened this issue Mar 28, 2024 · 3 comments
Assignees
@MadVikingGod @VinozzZ
Labels
instrumentation: otelhttp

Comments

@MadVikingGod
Copy link
Contributor

MadVikingGod commented Mar 28, 2024 •
edited by MrAlias
Loading

Make instrumentation/net/http/otelhttp produce Client Traces following the migration plan #5132.

A user should be able to produce Traces from the Transport in the current semconv (default), the latest semconv (1.26.0), and a duplicate form based on the Environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE

  • Produce Old Client Attributes
  • Produce Duplicate Client Attributes
  • Produce New Client Attributes
  • Add a changelog entry
@MadVikingGod MadVikingGod self-assigned this Apr 18, 2024
@MadVikingGod MadVikingGod mentioned this issue Jun 17, 2024
Merged
MrAlias added a commit that referenced this issue Jul 9, 2024
@MadVikingGod @MrAlias
HTTP Semconv migration Part1 Client - v1.24.0 support (#5773)
8846bcf 
This change adds the new semantic version (v1.24.0) attribute producer
to the semconv of otlehttp.

Part of #5332

---------

Co-authored-by: Aaron Clawson <MadVikingGod@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@VinozzZ
Copy link
Contributor

VinozzZ commented Jul 18, 2024

I would like to work on the remaining task for this issue

@VinozzZ
Copy link
Contributor

VinozzZ commented Jul 22, 2024

Implementation Plan:

  • Create a newHTTPClient that returns attributes from semconv v1.26.0
  • the newHTTPClient should implement RequestTraceAttrs, ResponseTraceAttrs, and Status methods
  • Add tests to check newHTTPClient is returning correct attributes
  • Add logic to check for environment variable OTEL_HTTP_CLIENT_COMPATIBILITY_MODE in HTTPClient to also return attributes from newHTTPClient if the env is set to http/dup. Otherwise, only return attributes from the oldHTTPClient

@VinozzZ VinozzZ mentioned this issue Jul 25, 2024
Merged
dmathieu added a commit that referenced this issue Aug 1, 2024
@VinozzZ @dmathieu
instrumentation/net/http/otelhttp: support duplicate both old and new…
7ee1471 
… attributes for HTTPClient (#5945)

This PR implements the HTTPClient that can duplicate attributes for old
semconv v1.20.0 and new semconv v1.26.0.
It's part of the migration plan #5332

---------

Co-authored-by: Damien Mathieu <42@dmathieu.com>
@MrAlias
Copy link
Contributor

MrAlias commented Aug 1, 2024

Done.

@MrAlias MrAlias closed this as completed Aug 1, 2024
luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@VinozzZ @dmathieu @luca-filipponi
instrumentation/net/http/otelhttp: support duplicate both old and new…
9c0b682 
… attributes for HTTPClient (open-telemetry#5945)

This PR implements the HTTPClient that can duplicate attributes for old
semconv v1.20.0 and new semconv v1.26.0.
It's part of the migration plan open-telemetry#5332

---------

Co-authored-by: Damien Mathieu <42@dmathieu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadVikingGod MadVikingGod

@VinozzZ VinozzZ

Labels
instrumentation: otelhttp
Projects
Go: HTTP Semconv Migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadVikingGod @MrAlias @VinozzZ