autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281

gouthamve · 2024-03-17T10:24:25Z

This will allow using the Prometheus bridge with autoexport.

The goal is to make it easy for any Prometheus exporter to also be able to emit OTLP. See: https://prometheus.io/blog/2024/03/14/commitment-to-opentelemetry/#otlp-export-in-the-ecosystem

codecov · 2024-03-17T10:29:42Z

Codecov Report

Attention: Patch coverage is 72.05882% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 62.4%. Comparing base (52576e4) to head (b889ef0).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #5281   +/-   ##
=====================================
  Coverage   62.3%   62.4%           
=====================================
  Files        189     189           
  Lines      11575   11638   +63     
=====================================
+ Hits        7219    7263   +44     
- Misses      4146    4158   +12     
- Partials     210     217    +7

Files	Coverage Δ
exporters/autoexport/registry.go	`100.0% <100.0%> (ø)`
exporters/autoexport/noop.go	`62.5% <0.0%> (-20.9%)`	⬇️
exporters/autoexport/metrics.go	`78.5% <76.1%> (-3.6%)`	⬇️

exporters/autoexport/metrics.go

dashpole

@gouthamve thanks for this! It will need an entry in CHANGELOG.md

gouthamve · 2024-03-31T11:19:07Z

Thanks for your review @dashpole!

Anything I can do to move this along @open-telemetry/go-approvers?

pellared · 2024-04-02T14:16:26Z

@gouthamve Sorry for the delay. I will do my best to review it this week.

exporters/autoexport/metrics.go

gouthamve · 2024-04-03T12:03:41Z

Thanks for the review @pellared. I did the easiest thing here and exposed the Config object. If you see a better way, please let me know.

Also, this seems a little counter-intuitive to me. We are using the same factory and Config interface for every signal type, but the options I added are only required for the "metric" signals.

gouthamve · 2024-04-06T06:40:41Z

Hi @pellared @dashpole took a stab at implementing what we discussed? Does this direction look good?

Will add unit tests once you confirm!

dashpole

implementation looks correct to me.

exporters/autoexport/metrics.go

gouthamve · 2024-04-14T11:26:34Z

@pellared @dashpole This is now ready for review!

I added the tests and also a WithFallbackMetricsProducer option. Thanks in advance for your review!

exporters/autoexport/metrics.go

exporters/autoexport/noop.go

Signed-off-by: gouthamve <gouthamve@gmail.com> Signed-off-by: Goutham <gouthamve@gmail.com>

Signed-off-by: Goutham <gouthamve@gmail.com>

Currently blocked on open-telemetry/opentelemetry-go-contrib#5281 Signed-off-by: Goutham <gouthamve@gmail.com>

CHANGELOG.md

exporters/autoexport/metrics.go

CHANGELOG.md

Co-authored-by: Robert Pająk <pellared@hotmail.com> Signed-off-by: gouthamve <gouthamve@gmail.com>

CHANGELOG.md

…pen-telemetry#5281)

### Added - Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (#3068, #3108) - Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to `go.opentelemetry.io/contrib/autoexport` to be set metrics producers. (#5281) - `prometheus` and `none` are supported values. You can specify multiple producers separated by a comma. - Add `WithFallbackMetricProducer` option that adds a fallback if the `OTEL_METRICS_PRODUCERS` is not set or empty. - The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace` module. This module provides a Baggage Span Processor. (#5404) - Add gRPC trace `Filter` for stats handler to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (#5196) - Add a repository Code Ownership Policy. (#5555) - The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This module provides an OpenTelemetry logging bridge for `github.com/sirupsen/logrus`. (#5355) - The `WithVersion` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the logged package version. (#5588) - The `WithSchemaURL` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the semantic convention schema URL for the logged records. (#5588) - Add support for Cloud Run jobs in `go.opentelemetry.io/contrib/detectors/gcp`. (#5559) ### Changed - The gRPC trace `Filter` for interceptor is renamed to `InterceptorFilter`. (#5196) - The gRPC trace filter functions `Any`, `All`, `None`, `Not`, `MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`, `ServicePrefix` and `HealthCheck` for interceptor are moved to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`. With this change, the filters in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` are now working for stats handler. (#5196) - `NewLogger` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the underlying `Handler`. (#5588) - `NewHandler` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the returned `Handler`. (#5588) - Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0` to `go.opentelemetry.io/otel/semconv/v1.25.0`. (#5605) ### Removed - The `WithInstrumentationScope` option function in `go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the `name` parameter added to `NewHandler` and `NewLogger` as well as `WithVersion` and `WithSchema` as replacements. (#5588) ### Deprecated - The `InterceptorFilter` type in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` is deprecated. (#5196)

### Added - Add the new `go.opentelemetry.io/contrib/instrgen` package to provide auto-generated source code instrumentation. (open-telemetry#3068, open-telemetry#3108) - Add an experimental `OTEL_METRICS_PRODUCERS` environment variable to `go.opentelemetry.io/contrib/autoexport` to be set metrics producers. (open-telemetry#5281) - `prometheus` and `none` are supported values. You can specify multiple producers separated by a comma. - Add `WithFallbackMetricProducer` option that adds a fallback if the `OTEL_METRICS_PRODUCERS` is not set or empty. - The `go.opentelemetry.io/contrib/processors/baggage/baggagetrace` module. This module provides a Baggage Span Processor. (open-telemetry#5404) - Add gRPC trace `Filter` for stats handler to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`. (open-telemetry#5196) - Add a repository Code Ownership Policy. (open-telemetry#5555) - The `go.opentelemetry.io/contrib/bridges/otellogrus` module. This module provides an OpenTelemetry logging bridge for `github.com/sirupsen/logrus`. (open-telemetry#5355) - The `WithVersion` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the logged package version. (open-telemetry#5588) - The `WithSchemaURL` option function in `go.opentelemetry.io/contrib/bridges/otelslog`. This option function is used as a replacement of `WithInstrumentationScope` to specify the semantic convention schema URL for the logged records. (open-telemetry#5588) - Add support for Cloud Run jobs in `go.opentelemetry.io/contrib/detectors/gcp`. (open-telemetry#5559) ### Changed - The gRPC trace `Filter` for interceptor is renamed to `InterceptorFilter`. (open-telemetry#5196) - The gRPC trace filter functions `Any`, `All`, `None`, `Not`, `MethodName`, `MethodPrefix`, `FullMethodName`, `ServiceName`, `ServicePrefix` and `HealthCheck` for interceptor are moved to `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters/interceptor`. With this change, the filters in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` are now working for stats handler. (open-telemetry#5196) - `NewLogger` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the underlying `Handler`. (open-telemetry#5588) - `NewHandler` now accepts a `name` `string` as the first argument. This parameter is used as a replacement of `WithInstrumentationScope` to specify the name of the logger backing the returned `Handler`. (open-telemetry#5588) - Upgrade all dependencies of `go.opentelemetry.io/otel/semconv/v1.24.0` to `go.opentelemetry.io/otel/semconv/v1.25.0`. (open-telemetry#5605) ### Removed - The `WithInstrumentationScope` option function in `go.opentelemetry.io/contrib/bridges/otelslog` is removed. Use the `name` parameter added to `NewHandler` and `NewLogger` as well as `WithVersion` and `WithSchema` as replacements. (open-telemetry#5588) ### Deprecated - The `InterceptorFilter` type in `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` is deprecated. (open-telemetry#5196)

gouthamve requested a review from pellared as a code owner March 17, 2024 10:24

gouthamve requested a review from a team March 17, 2024 10:24

dashpole reviewed Mar 18, 2024

View reviewed changes

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

dashpole reviewed Mar 18, 2024

View reviewed changes

pellared requested changes Apr 3, 2024

View reviewed changes

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

gouthamve force-pushed the autoexport-add-support-for-providers branch from afc9715 to 1ee0485 Compare April 3, 2024 12:02

gouthamve force-pushed the autoexport-add-support-for-providers branch 3 times, most recently from b7e8cda to 9f01a62 Compare April 6, 2024 06:38

gouthamve force-pushed the autoexport-add-support-for-providers branch from 9f01a62 to 93900a4 Compare April 6, 2024 06:41

dashpole reviewed Apr 6, 2024

View reviewed changes

exporters/autoexport/metrics.go Show resolved Hide resolved

exporters/autoexport/metrics.go Show resolved Hide resolved

gouthamve force-pushed the autoexport-add-support-for-providers branch 2 times, most recently from 1155097 to faf3f01 Compare April 14, 2024 11:02

gouthamve requested a review from pellared April 14, 2024 11:09

gouthamve force-pushed the autoexport-add-support-for-providers branch 3 times, most recently from bce3445 to d1eda11 Compare April 14, 2024 11:24

gouthamve mentioned this pull request Apr 14, 2024

prometheusbridge: Creates invalid exemplars for Prometheus counters #5383

Closed

dashpole reviewed Apr 15, 2024

View reviewed changes

exporters/autoexport/metrics.go Show resolved Hide resolved

dashpole reviewed Apr 15, 2024

View reviewed changes

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

gouthamve force-pushed the autoexport-add-support-for-providers branch 3 times, most recently from b2d37af to f3168b9 Compare April 24, 2024 09:58

dashpole reviewed Apr 24, 2024

View reviewed changes

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/noop.go Outdated Show resolved Hide resolved

gouthamve added 5 commits April 24, 2024 19:05

Add Changelog entry

860d914

Signed-off-by: gouthamve <gouthamve@gmail.com> Signed-off-by: Goutham <gouthamve@gmail.com>

Add support for multiple producers

9bd819e

Signed-off-by: Goutham <gouthamve@gmail.com>

Add none option for metrics producers

4f5d71f

Signed-off-by: Goutham <gouthamve@gmail.com>

Update doc section of NewMetricReader

796e08d

Signed-off-by: Goutham <gouthamve@gmail.com>

review feedback

b049186

Signed-off-by: Goutham <gouthamve@gmail.com>

gouthamve force-pushed the autoexport-add-support-for-providers branch from 10c14b1 to b049186 Compare April 24, 2024 17:05

dashpole approved these changes Apr 24, 2024

View reviewed changes

gouthamve mentioned this pull request Apr 26, 2024

Environment variable to set metrics producers open-telemetry/opentelemetry-specification#4015

Closed

Merge branch 'main' into autoexport-add-support-for-providers

7c327f4

gouthamve added a commit to grafana/unused that referenced this pull request May 5, 2024

Add experimental support for OTLP Exporter

87d371e

Currently blocked on open-telemetry/opentelemetry-go-contrib#5281 Signed-off-by: Goutham <gouthamve@gmail.com>

gouthamve mentioned this pull request May 5, 2024

Add experimental support for OTLP Exporter grafana/unused#98

Draft

Merge branch 'main' into autoexport-add-support-for-providers

6d9c443

pellared reviewed May 6, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

exporters/autoexport/metrics.go Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestions from code review

4e3ac55

Co-authored-by: Robert Pająk <pellared@hotmail.com> Signed-off-by: gouthamve <gouthamve@gmail.com>

gouthamve force-pushed the autoexport-add-support-for-providers branch from cee6b6c to 4e3ac55 Compare May 6, 2024 13:29

pellared reviewed May 6, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pellared added 2 commits May 6, 2024 15:40

Update CHANGELOG.md

49eaf8a

Update CHANGELOG.md

b889ef0

pellared changed the title ~~[autoexport] Add support for metric.Producers~~ autoexport: Add support for metric.Producers May 6, 2024

pellared changed the title ~~autoexport: Add support for metric.Producers~~ autoexport: Add OTEL_METRICS_PRODUCERS environment variable support May 6, 2024

pellared approved these changes May 6, 2024

View reviewed changes

pellared merged commit b46d700 into open-telemetry:main May 6, 2024
23 checks passed

gouthamve deleted the autoexport-add-support-for-providers branch May 6, 2024 15:50

pellared added a commit to pellared/opentelemetry-go-contrib that referenced this pull request May 6, 2024

Fix changelog for open-telemetry#5281

3fbd3f9

pellared added a commit that referenced this pull request May 6, 2024

Fix changelog for #5281 (#5450)

f251adc

zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 7, 2024

autoexport: Add OTEL_METRICS_PRODUCERS environment variable support (o…

173aef1

…pen-telemetry#5281)

zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request May 7, 2024

Fix changelog for open-telemetry#5281 (open-telemetry#5450)

2d5a8c8

MrAlias mentioned this pull request May 21, 2024

Release v1.27.0/v0.52.0/v0.21.0/v0.7.0/v0.2.0 #5628

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281

autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281

gouthamve commented Mar 17, 2024 •

edited

Loading

codecov bot commented Mar 17, 2024 •

edited

Loading

dashpole left a comment

gouthamve commented Mar 31, 2024

pellared commented Apr 2, 2024

gouthamve commented Apr 3, 2024

gouthamve commented Apr 6, 2024

dashpole left a comment

gouthamve commented Apr 14, 2024

autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281

autoexport: Add OTEL_METRICS_PRODUCERS environment variable support #5281

Conversation

gouthamve commented Mar 17, 2024 • edited Loading

codecov bot commented Mar 17, 2024 • edited Loading

Codecov Report

dashpole left a comment

Choose a reason for hiding this comment

gouthamve commented Mar 31, 2024

pellared commented Apr 2, 2024

gouthamve commented Apr 3, 2024

gouthamve commented Apr 6, 2024

dashpole left a comment

Choose a reason for hiding this comment

gouthamve commented Apr 14, 2024

gouthamve commented Mar 17, 2024 •

edited

Loading

codecov bot commented Mar 17, 2024 •

edited

Loading