otellogr: Implement LevelSeverity, Enabled #6206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6206 +/- ##
=====================================
Coverage 67.0% 67.1%
=====================================
Files 194 194
Lines 12658 12671 +13
=====================================
+ Hits 8492 8503 +11
- Misses 3888 3889 +1
- Partials 278 279 +1
|
scorpionknifes
changed the title
dmathieu
added
the
Skip Changelog
dmathieu
reviewed
Oct 7, 2024
| ) | ||
| otellogr.WithLoggerProvider(provider), | ||
| // Optionally, set the log level severity mapping. | ||
| otellogr.WithLevelSeverity(func(i int) log.Severity { |
There was a problem hiding this comment.
I wonder what the use case is for this. When would folks want to change the severity mapping?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a few methods for otellogr package
Please add skip changelog thx 🙏
Part of #5192