Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply jitter once per lifetime, not once per stream #199

Merged
merged 5 commits into from
May 22, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented May 21, 2024

Fixes #198.

Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacd jmacd merged commit b3f7682 into open-telemetry:main May 22, 2024
2 checks passed
@jmacd jmacd deleted the jmacd/morejittery branch May 22, 2024 18:58
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Jun 11, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/open-telemetry/otel-arrow](https://togithub.com/open-telemetry/otel-arrow)
| `v0.23.0` -> `v0.24.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fopen-telemetry%2fotel-arrow/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fopen-telemetry%2fotel-arrow/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fopen-telemetry%2fotel-arrow/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fopen-telemetry%2fotel-arrow/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>open-telemetry/otel-arrow
(github.com/open-telemetry/otel-arrow)</summary>

###
[`v0.24.0`](https://togithub.com/open-telemetry/otel-arrow/releases/tag/v0.24.0)

[Compare
Source](https://togithub.com/open-telemetry/otel-arrow/compare/v0.23.0...v0.24.0)

Jitter is applied to once per process, not once per stream.
[https://github.com/open-telemetry/otel-arrow/pull/199](https://togithub.com/open-telemetry/otel-arrow/pull/199)
Network statistics tracing instrumentation simplified.
[https://github.com/open-telemetry/otel-arrow/pull/201](https://togithub.com/open-telemetry/otel-arrow/pull/201)
Protocol includes use of more gRPC codes.
[https://github.com/open-telemetry/otel-arrow/pull/202](https://togithub.com/open-telemetry/otel-arrow/pull/202)
Receiver concurrency bugfix.
[https://github.com/open-telemetry/otel-arrow/pull/205](https://togithub.com/open-telemetry/otel-arrow/pull/205)
Concurrent batch processor size==0 bugfix.
[https://github.com/open-telemetry/otel-arrow/pull/208](https://togithub.com/open-telemetry/otel-arrow/pull/208)
New integration testing.
[https://github.com/open-telemetry/otel-arrow/pull/210](https://togithub.com/open-telemetry/otel-arrow/pull/210)
Use gRPC Status codes in the Arrow exporter.
[https://github.com/open-telemetry/otel-arrow/pull/211](https://togithub.com/open-telemetry/otel-arrow/pull/211)
Fix stream-shutdown race in Arrow receiver.
[https://github.com/open-telemetry/otel-arrow/pull/212](https://togithub.com/open-telemetry/otel-arrow/pull/212)
Avoid work for already-canceled requests.
[https://github.com/open-telemetry/otel-arrow/pull/213](https://togithub.com/open-telemetry/otel-arrow/pull/213)
Call IPCReader.Err() after reader loop.
[https://github.com/open-telemetry/otel-arrow/pull/215](https://togithub.com/open-telemetry/otel-arrow/pull/215)
Update to Arrow-Go v16.1.0.
[https://github.com/open-telemetry/otel-arrow/pull/218](https://togithub.com/open-telemetry/otel-arrow/pull/218)
Update to OpenTelemetry Collector v0.102.x.
[https://github.com/open-telemetry/otel-arrow/pull/219](https://togithub.com/open-telemetry/otel-arrow/pull/219)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the per-stream jitter parameter
2 participants