Return nil from Server on stream shutdown #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
reviewed
Aug 24, 2023
moh-osman3
force-pushed
the
mohosman/server-return-ok-on-shutdown
branch
from
8a8ba7a
to
a4ca19f
Compare
jmacd
reviewed
Aug 29, 2023
jmacd
reviewed
Aug 29, 2023
lquerel
approved these changes
Aug 30, 2023
jmacd
pushed a commit
that referenced
this pull request
Aug 31, 2023
After merging #24, unit tests for otelarrowreceiver were failing and I did not catch that. This PR fixes the unit tests by adding in support for an extra call to Send() the receiver will do (with arrowpb.StatusCode_STREAM_SHUTDOWN), to signal shutdown to the client. Addresses #29 (comment)
Merged
jmacd
added a commit
that referenced
this pull request
Aug 31, 2023
Release v0.3.0 includes: - #24 - #29 - #30 - #36 This release includes a BREAKING CHANGE 🛑 🛑 🛑 🛑 🛑. We do not anticipate another of these, it merely renames/enumbers status codes to match the gRPC status code numbering scheme. However, since status code 0 stays the same, it will result in unusual looking errors but should be safe to deploy the receivers first. Their CANCELED (i.e., SERVER_SHUTDOWN) will read as UNAVAILABLE, etc. See #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Applying learning from grpc/grpc-go#6504 (comment), which pointed out that the server is return EOF directly when the client calls CloseSend(), which is causing an error signal on spans.
Instead the server should check if it received EOF from client (indicating CloseSend() was called) and send StatusOK to the client. The client will know to restart the stream when it gets a response with
batchID=-1andstatus=OK.