Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Allow Nesting of Sync/Async VectorEnvs #2104

Closed
wants to merge 19 commits into from
Closed

Bugfix: Allow Nesting of Sync/Async VectorEnvs #2104

wants to merge 19 commits into from

Commits on Apr 5, 2022

  1. Bugfix: Allow nesting of Sync/Async VectorEnvs 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8af640b View commit details
    Browse the repository at this point in the history

  2. Add support for wrapped inner VectorEnvs 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    20aac89 View commit details
    Browse the repository at this point in the history

  3. Minor change in test for nesting of VectorEnvs 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5f5abcf View commit details
    Browse the repository at this point in the history

  4. Make test a bit clearer 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    02af0da View commit details
    Browse the repository at this point in the history

  5. Update tests a bit and fix bugs with bool(array) 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    846d026 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Fix pre-commit issues 

    Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
    @lebrice
    lebrice committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    332d55b View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Remove unused imports 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    49ee209 View commit details
    Browse the repository at this point in the history

  2. Remove with-block from test 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f47596f View commit details
    Browse the repository at this point in the history

  3. Fix pre-commit flake8 errors 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    5f2e339 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Remove unused step_fn in async_vector_env.py 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 2, 2022
    Configuration menu
    Copy the full SHA
    fcebd76 View commit details
    Browse the repository at this point in the history

  2. Remove if block with pass statement 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 2, 2022
    Configuration menu
    Copy the full SHA
    055087b View commit details
    Browse the repository at this point in the history

  3. Parametrize with all envs, make test more robust 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 2, 2022
    Configuration menu
    Copy the full SHA
    9c0e308 View commit details
    Browse the repository at this point in the history

  4. Fix warnings in test 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c9f4d50 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Remove other unused step_fn 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 3, 2022
    Configuration menu
    Copy the full SHA
    15208e3 View commit details
    Browse the repository at this point in the history

  2. Reuse should_skip_env_for_test logic 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 3, 2022
    Configuration menu
    Copy the full SHA
    c9cfe2e View commit details
    Browse the repository at this point in the history

  3. Minor touch-ups 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 3, 2022
    Configuration menu
    Copy the full SHA
    b08c2b4 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Fix typos and type errors in test util function 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5791789 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix-nesting-vectorenvs

    @lebrice
    lebrice committed May 18, 2022
    Configuration menu
    Copy the full SHA
    3a42311 View commit details
    Browse the repository at this point in the history

  3. Fix error in test, make quicker, fix pre-commit 

    Signed-off-by: Fabrice Normandin <normandf@mila.quebec>
    @lebrice
    lebrice committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c62cceb View commit details
    Browse the repository at this point in the history