Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.20 #915

Merged
merged 3 commits into from
May 8, 2023
Merged

Update Go to 1.20 #915

merged 3 commits into from
May 8, 2023

Conversation

michaelsauter
Copy link
Member

@michaelsauter michaelsauter commented May 5, 2023

Also update golangci-lint and go-junit-report.

Closes #877.

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@michaelsauter michaelsauter self-assigned this May 5, 2023
@michaelsauter michaelsauter force-pushed the feature/update-go branch 3 times, most recently from a8b1a03 to c3fb79d Compare May 5, 2023 09:48
Also update golangci-lint and go-junit-report.

Closes #877.
@BraisVQ
Copy link
Contributor

BraisVQ commented May 8, 2023

I have tested this successfully:

  • Provision new version of the quickstarter with new agent.
  • Build old version of the quickstarter with new agent.

@michaelsauter
Copy link
Member Author

@braisvq1996 Thank you! I also tested that building the agent image works, and I rebuilt an existing project using the new agent image. From my side, this is ready to be merged now.

@michaelsauter michaelsauter marked this pull request as ready for review May 8, 2023 10:11
@michaelsauter michaelsauter requested a review from BraisVQ May 8, 2023 10:11
Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelsauter michaelsauter merged commit 1bcf976 into master May 8, 2023
@michaelsauter michaelsauter deleted the feature/update-go branch May 8, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance of Golang agent and quickstarter
2 participants