Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: excluder: An R package that checks for exclusion criteria in online data #3889

Closed
whedon opened this issue Nov 4, 2021 · 26 comments
Assignees
Labels
pre-review R rOpenSci Submissions associated with rOpenSci

Comments

@whedon
Copy link

whedon commented Nov 4, 2021

Submitting author: @JeffreyRStevens (Jeffrey R Stevens)
Repository: https://github.com/ropensci/excluder/
Version: v0.3.1
Editor: @danielskatz
Reviewers: @danielskatz
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/25a045841e7e91fdc25745cc458a1fd6"><img src="https://joss.theoj.org/papers/25a045841e7e91fdc25745cc458a1fd6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/25a045841e7e91fdc25745cc458a1fd6/status.svg)](https://joss.theoj.org/papers/25a045841e7e91fdc25745cc458a1fd6)

Author instructions

Thanks for submitting your paper to JOSS @JeffreyRStevens. Currently, there isn't an JOSS editor assigned to your paper.

@JeffreyRStevens if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Nov 4, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Nov 4, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.12 s (738.5 files/s, 119196.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            30           1452            386           5253
R                               27            296           1419           2071
Markdown                         6            211              0            849
CSS                              3             99             48            428
JSON                             1              0              0            303
JavaScript                       3             64             32            256
SVG                              9              0              1            179
YAML                             5             26              2            142
Rmd                              2             86            177            101
-------------------------------------------------------------------------------
SUM:                            86           2234           2065           9582
-------------------------------------------------------------------------------


Statistical information for the repository '8f1b3b2c7f80c1a279cf0928' was
gathered on 2021/11/04.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Jeffrey Stevens                  1           352              0          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Jeffrey R. Stevens          352          100.0         -0.0                9.09

@whedon whedon added the R label Nov 4, 2021
@whedon
Copy link
Author

whedon commented Nov 4, 2021

PDF failed to compile for issue #3889 with the following error:

 Can't find any papers to compile :-(

@danielskatz
Copy link

@whedon generate pdf from branch paper

@whedon
Copy link
Author

whedon commented Nov 4, 2021

Attempting PDF compilation from custom branch paper. Reticulating splines etc...

@danielskatz
Copy link

@whedon check references from branch paper

@whedon
Copy link
Author

whedon commented Nov 4, 2021

Attempting to check references... from custom branch paper

@whedon
Copy link
Author

whedon commented Nov 4, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/13645579.2018.1563966 is OK
- 10.1177/1948550619875149 is OK
- 10.3758/s13428-021-01694-3 is OK
- 10.21105/joss.01686 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Nov 4, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @mikldk - would you be able to edit this JOSS submission?

@danielskatz
Copy link

@whedon invite @mikldk as editor

@whedon
Copy link
Author

whedon commented Nov 4, 2021

@mikldk has been invited to edit this submission.

@mikldk
Copy link

mikldk commented Nov 5, 2021

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Nov 5, 2021

OK, the editor is @mikldk

@mikldk
Copy link

mikldk commented Nov 5, 2021

@JeffreyRStevens - thank you for the submission.

Do you have any suggestions for reviewers (here is a list of potential reviewers)?

@JeffreyRStevens
Copy link

Thanks, @mikldk. The package has already been peer reviewed in rOpenSci by Joseph O'Brien (@jmobrien) and Julia Silge (@juliasilge) at ropensci/software-review#455. Is there a fast-track review option since it has already been peer reviewed? If so, do you still need additional reviewers?
Thanks.

@danielskatz
Copy link

Yes, sorry, I was not aware of this when I asked @mikldk to edit. I'll take this back and run this through quickly, in the next day or few hopefully.

@danielskatz
Copy link

@whedon assign me as editor

@whedon
Copy link
Author

whedon commented Nov 5, 2021

OK, the editor is @danielskatz

@JeffreyRStevens
Copy link

@danielskatz, OK--thanks. Note that the reviewers did not review the paper, just the package.

@danielskatz
Copy link

right - that's typical - I will review the paper as part of the process

@danielskatz
Copy link

@ehedon assign @danielskatz as reviewer

@danielskatz
Copy link

@whedon assign @danielskatz as reviewer

@whedon whedon assigned danielskatz and unassigned danielskatz Nov 5, 2021
@whedon
Copy link
Author

whedon commented Nov 5, 2021

OK, @danielskatz is now a reviewer

@danielskatz
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Nov 5, 2021

OK, I've started the review over in #3893.

@whedon whedon closed this as completed Nov 5, 2021
@danielskatz danielskatz added the rOpenSci Submissions associated with rOpenSci label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review R rOpenSci Submissions associated with rOpenSci
Projects
None yet
Development

No branches or pull requests

4 participants