Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conan from SDK, Disable unicode component by default, Bump version #933

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

AmyrAhmady
Copy link
Member

@AmyrAhmady AmyrAhmady commented Jun 30, 2024

Removal of conan from SDK, adding dependencies as submodules

I removed conan usage from SDK so we can do the same for SDK repository, I believe being glued to conan is not practical and that useful for projects depending on open.mp SDK, just a bunch of git submodules for dependencies do the job, they don't need more I will do the required changes to SDK repository as well when this gets merged.
Also as we discussed, Merging SDK and making it a submodule to open.mp repository is also an option I didn't take, specially since there's no frequent changes anymore to annoy us

Advantages of adding SDK as a submodule:

  • Removes the code/file duplication problem and makes us not need to update SDK repository using github CI on each release, just keeping it as is.
  • Having a proper history for SDK repository, since right now it's all single commits from github CI pushing all changes at once.

Disabling Unicode component by default

Unicode component is disabled by default now since ICU takes a lot of build time and later the output is also big, and lack of actual proper usage makes it basically useless in here. A huge library for only 3 texts

Version Bump

Also bumped version to 1.3.1, why that .1 at the end? idk either +:infinitylul:

Hual
Hual previously approved these changes Jul 12, 2024
@AmyrAhmady AmyrAhmady merged commit 8118b0d into master Jul 12, 2024
13 of 14 checks passed
@AmyrAhmady AmyrAhmady deleted the amir/no-conan-sdk branch July 12, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants