UPSTREAM: google/cadvisor: 1573: Ignore any .mount cgroup in docker #12489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see: google/cadvisor#1573 |
derekwaynecarr
changed the title
|
marking do not merge until upstream pr merges. |
derekwaynecarr
force-pushed
the
cadvisor-1573
branch
from
727315a
to
c8992fc
Compare
derekwaynecarr
changed the title
derekwaynecarr
force-pushed
the
cadvisor-1573
branch
from
c8992fc
to
4689243
Compare
|
[test] |
|
Evaluated for origin test up to 4689243 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/705/) (Base Commit: 46942ad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using docker 1.12, you now get .mounts for anything associated with the dockershim, and we need to ignore them in favor of the usage associated with the .scope suffix for the container.
For example, cadvisor should ignore mounts of the following form: