Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove end_date parameter #2315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Jabolol
Copy link
Contributor

@Jabolol Jabolol commented Oct 4, 2024

Fixes #2300 by removing end_date parameter to partitions. TLDR; end_date was computed once when Dagster was deployed, making it miss future partitions.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kariba-network ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:16pm
oso-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:16pm

Copy link

@oso-prs oso-prs bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved! please merge responsibly 😄

@oso-prs
Copy link

oso-prs bot commented Oct 4, 2024

Test deployment unnecessary, no dbt files have been changed.

Copy link
Member

@ccerv1 ccerv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing partition materialisations in dlt_assets jobs
2 participants