Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Assigning an existing geographic location is broken #85

Closed
nemesifier opened this issue Feb 18, 2021 · 1 comment
Closed

[bug] Assigning an existing geographic location is broken #85

nemesifier opened this issue Feb 18, 2021 · 1 comment
Assignees
@niteshsinha17

Comments

@nemesifier
Copy link
Member

How to replicate:

  • create a device
  • create a geographic location in a separate step
  • go to the device created in the first step, then go to map tab, select "Existing"
  • select the geographic location just created
  • hit save

Expected result:

  • when the location is selected, the geo information should appear
  • device is saved normally

Actual result:

  • when the location is selected, the geo information does not appear
  • device is not saved because a validation error
@purhan purhan self-assigned this Mar 2, 2021
@purhan purhan removed their assignment Mar 12, 2021
@niteshsinha17 niteshsinha17 self-assigned this Mar 12, 2021
@niteshsinha17
Copy link
Member

@nemesisdesign This Issue is coming from django-loci. I have confirmed and solved it.

@niteshsinha17 niteshsinha17 transferred this issue from openwisp/openwisp-controller Mar 12, 2021
niteshsinha17 added a commit to niteshsinha17/django-loci that referenced this issue Mar 12, 2021
@niteshsinha17
[fix] Fixed not assigning of an existing geographic location openwisp#85
7e0a90e 


closes openwisp#85
@niteshsinha17 niteshsinha17 mentioned this issue Mar 12, 2021
Closed
nemesifier added a commit that referenced this issue Mar 16, 2021
@nemesifier
[fix] Fixed geo location inline flow #85
f726c6d 
It was broken by the change in the django JS code
(removal of the windowname_to_id function).

Closes #85
nemesifier added a commit that referenced this issue Mar 16, 2021
@nemesifier
Merge tag '0.4.2'
8f362b0 
Version 0.4.2 [2021-03-16]

- Fixed broken UI in inline geo selection flow caused by a JS change in django
  (`issue #85 <https://github.com/openwisp/django-loci/issues/85>`_)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niteshsinha17 niteshsinha17

Labels
None yet
Projects
OpenWISP Priorities for next releases
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fixed not assigning of an existing geographic location #85 niteshsinha17/django-loci
3 participants
@nemesifier @purhan @niteshsinha17