Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Adjust or remove strict test #90

Closed
nemesifier opened this issue Jun 29, 2021 · 4 comments · Fixed by #97
Closed

[change] Adjust or remove strict test #90

nemesifier opened this issue Jun 29, 2021 · 4 comments · Fixed by #97

Comments

@nemesifier
Copy link
Member

nemesifier commented Jun 29, 2021

This strict test feature is backfiring quite a bit.

It's triggered every time django is initialized, also with scripts, management commands, celery, etc.

We should address this, maybe we can turn this into a management command to execute only some times.

@pniaps
Copy link
Member

pniaps commented Sep 18, 2021

Agree with that. I have installed a controller in a local network without internet and had to disable it.

@nemesifier
Copy link
Member Author

Maybe we could simply remove it to simplify our life.

@minhng99
Copy link

minhng99 commented Oct 1, 2021

image
Yep, having this issue when boot up, set that var to False fixed it!

@nemesifier
Copy link
Member Author

We could convert this to use system checks. This way it would be run only when the check command is called. We should also make sure this check is not done when DEBUG is True.

We could also issue a warning instead of an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants