Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed six dependency #197

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Removed six dependency #197

merged 1 commit into from
Sep 28, 2019

Conversation

MightySCollins
Copy link
Contributor

Django 3 has now removed the six util module but this package already seems to only support higher than Python 3.4 as of version 0.14.x.

@auvipy
Copy link
Collaborator

auvipy commented Sep 16, 2019

we need to wait for this.

@codingjoe
Copy link
Contributor

codingjoe commented Sep 26, 2019

@auvipy why do we need to wait and what for? This prevents me from testing Django 3.0a1 against some of my test suites. Would it be ok, to simply try ... except the import and use str for the places where the import fails?

@MightySCollins
Copy link
Contributor Author

I am happy to change the PR to try ... except the only reason I did not was because according to the README Python 2 has already been dropped.

@codingjoe
Copy link
Contributor

@MightySCollins true, that shouldn't be needed, however we do need to get the test suite for Django 3.0 running, I gave it a shot in #200, but I am out in the woods for a couple days. Be my guest to fix it. Would be great if you get it running 👍

@auvipy auvipy closed this Sep 28, 2019
@auvipy auvipy reopened this Sep 28, 2019
@auvipy auvipy merged commit ed39101 into openwisp:master Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants