Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Implement clustering feature #114 #162

Merged
merged 10 commits into from
Oct 18, 2022

Conversation

totallynotvaishnav
Copy link
Member

@totallynotvaishnav totallynotvaishnav commented Sep 8, 2022

To do

  • Update docs
  • Add tests

closes #114

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will have a closer look tomorrow, in the meanwhile I can notice there's no mention of this feature in the README section in which the demos are listed (Different demos).

@totallynotvaishnav totallynotvaishnav force-pushed the issues/114-add-node-clustering branch 2 times, most recently from 6995920 to e1acec9 Compare September 21, 2022 15:21
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in the context of the map for OpenWISP, how can we cluster nodes which have different status (online, problem, offline, unknown) without losing the power of the overview of the map?

The map is useful to visualize the network on the map and know at glance if there's any area which is not working.

If we cluster all the nodes only in 1 cluster, without differentiating anything, we lose this powerful feature.

How can we cluster only nodes of the same type? That is, cluster the active node together, then the problem nodes, the offline nodes, the unknown nodes. So that when the map is viewed, the user knows how many nodes are experiencing problems.

With the current clustering I see on openwisp/openwisp-monitoring#433, this information is lost.

@totallynotvaishnav totallynotvaishnav force-pushed the issues/114-add-node-clustering branch 3 times, most recently from 6b63446 to 7e5ead6 Compare October 9, 2022 20:46
@nemesifier nemesifier merged commit 7022761 into gsoc22 Oct 18, 2022
@nemesifier nemesifier deleted the issues/114-add-node-clustering branch October 18, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants