Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Reduce max zoom level to prevent unintended behavior due to exc… #260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

d1vyanshu-kumar
Copy link

Adjust the max zoom level to mitigate excessive zooming behaviour. Set zoom sensitivity and max zoom value from 32 to 15.

zoom.mov

@d1vyanshu-kumar
Copy link
Author

@nemesifier please review it.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d1vyanshu-kumar no need to close and reopen the PR, just force push next time.

It doesn't seem to me that any parameter you are adding here is configurable by the user, why hardcoding arbitrary settings in a library which is designed to be flexible?

lib/js/echarts-leaflet/LeafletModel.js Show resolved Hide resolved
@@ -44,6 +48,7 @@ export default function extendLeafletModel(echarts) {
},
],
layerControl: {},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants