Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile cityhash code into libzfs #10152

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Compile cityhash code into libzfs #10152

merged 1 commit into from
Mar 27, 2020

Conversation

ahrens
Copy link
Member

@ahrens ahrens commented Mar 24, 2020

Motivation and Context

Make the cityhash code compile into libzfs, in preparation for the new
"zstream" command, which I'll be opening a PR for later this week.

Description

Add this file to the list of "common" source files.

How Has This Been Tested?

compiled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ahrens
Compile cityhash code into libzfs
647006b 
Make the cityhash code compile into libzfs, in preparation for the new
"zstream" command.

Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
@ahrens ahrens requested a review from pcd1193182 March 24, 2020 18:45
@ahrens ahrens added Status: Code Review Needed Ready for review and testing Type: Building Indicates an issue related to building binaries labels Mar 24, 2020
pcd1193182
pcd1193182 approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@pcd1193182 pcd1193182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we using cityhash for in the zstream command? I guess I'll see when the review is published.

@ahrens
Copy link
Member Author

ahrens commented Mar 25, 2020

@pcd1193182 I should have the review out later today, but it's for the hash table described under "implementation details" in #10124.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 26, 2020
@behlendorf behlendorf merged commit 3f38797 into openzfs:master Mar 27, 2020
sdimitro pushed a commit to sdimitro/zfs that referenced this pull request Apr 2, 2020
@ahrens @sdimitro
Compile cityhash code into libzfs
ceb1279 
Make the cityhash code compile into libzfs, in preparation for the new
"zstream" command.

Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#10152
bgly pushed a commit to buurst/zfs that referenced this pull request Jul 17, 2020
@ahrens
Compile cityhash code into libzfs
7c132fc 
Make the cityhash code compile into libzfs, in preparation for the new
"zstream" command.

Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#10152
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ahrens @jsai20
Compile cityhash code into libzfs
896f666 
Make the cityhash code compile into libzfs, in preparation for the new
"zstream" command.

Reviewed-by: Paul Dagnelie <pcd@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes openzfs#10152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcd1193182 pcd1193182 pcd1193182 approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrens @pcd1193182 @behlendorf