RFC [buildbot] Illumos-5701 zpool list reports incorrect "alloc" value for cache devices #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernelOfTruth
changed the title
Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: George Wilson <george@delphix.com> Reviewed by: Alek Pinchuk <alek.pinchuk@nexenta.com> Approved by: Dan McDonald <danmcd@omniti.com> arc_space_return(HDR_L2ONLY_SIZE, ARC_SPACE_L2HDRS); correctly placed at @arc_hdr_l2hdr_destroy(arc_buf_hdr_t *hdr) ? Block: + /* + * If the l2hdr's b_daddr is equal to L2ARC_ADDR_UNSET, then + * this header is being processed by l2arc_write_buffers() (i.e. + * it's in the first stage of l2arc_write_buffers()). + * Re-affirming that truth here, just to serve as a reminder. If + * b_daddr does not equal L2ARC_ADDR_UNSET, then the header may or + * may not have its HDR_L2_WRITING flag set. (the write may have + * completed, in which case HDR_L2_WRITING will be false and the + * b_daddr field will point to the address of the buffer on disk). + */ +// IMPLY(l2hdr->b_daddr == L2ARC_ADDR_UNSET, HDR_L2_WRITING(hdr)); lines 1883 to 1893 applicable to ZFSOnLinux ? References: https://www.illumos.org/issues/5701 illumos/illumos-gate@a52fc31 Ported by: kernelOfTruth kerneloftruth@gmail.com
kernelOfTruth
force-pushed
the
zfs_master_12.06.2015_illumos-5701
branch
from
347a8df
to
1a6cf0d
Compare
kernelOfTruth
changed the title
kernelOfTruth
changed the title
|
@behlendorf is the block with
needed on ZFSOnLinux - it seems to be specific to Illumos derivatives and a previous "incarnation" of this patch has been tested positively with that part commented out also I'm not sure if
was correctly placed at @arc_hdr_l2hdr_destroy(arc_buf_hdr_t *hdr) in that port |
|
Merged to master as: d962d5d Illumos 5701 - zpool list reports incorrect "alloc" value for cache devi Expect a follow up patch stack fairly soon to resolve as many of the outstanding ARC discrepancies between upstream and ZoL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: Matthew Ahrens mahrens@delphix.com
Reviewed by: George Wilson george@delphix.com
Reviewed by: Alek Pinchuk alek.pinchuk@nexenta.com
Approved by: Dan McDonald danmcd@omniti.com
RFC:
was
arc_space_return(HDR_L2ONLY_SIZE, ARC_SPACE_L2HDRS);
correctly placed at
@arc_hdr_l2hdr_destroy(arc_buf_hdr_t *hdr)
?
Block:
1883 to 1893 applicable to ZFSOnLinux ?