Cancel initialize and TRIM before vdev_metaslab_fini() #9751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
added
Component: Test Suite
Any running 'zpool initialize' or TRIM must be cancelled prior to the vdev_metaslab_fini() call in spa_vdev_remove_log() which will unload the metaslabs and set ms->ms_group == NULL. TEST_ZTEST_TIMEOUT=7200 Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#8602
behlendorf
force-pushed
the
issue-8602
branch
from
3893945
to
4447e29
Compare
Codecov Report
@@ Coverage Diff @@
## master #9751 +/- ##
========================================
+ Coverage 80% 80% +<1%
========================================
Files 385 385
Lines 121302 121302
========================================
+ Hits 96442 96775 +333
+ Misses 24860 24527 -333
Continue to review full report at Codecov.
|
PrivatePuffin
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Seems like a reasonable cause and fix!
Thanks for your work on this issue, it was a pain when doing testing on zstd last few weeks!
I can confirm your testing is valid @behlendorf
While doing many runs of zstd for zstd last few weeks, it hits about 0.6 times in every push on buildbot.
A few hours of zloop on a faster machine would've atleast had one of these.
LGTM.
|
@ikozhukhov might want to review this. |
ikozhukhov
approved these changes
Dec 20, 2019
behlendorf
added
Status: Accepted
allanjude
pushed a commit
to allanjude/zfs
that referenced
this pull request
Dec 28, 2019
Any running 'zpool initialize' or TRIM must be cancelled prior to the vdev_metaslab_fini() call in spa_vdev_remove_log() which will unload the metaslabs and set ms->ms_group == NULL. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8602 Closes openzfs#9751
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 2, 2020
Any running 'zpool initialize' or TRIM must be cancelled prior to the vdev_metaslab_fini() call in spa_vdev_remove_log() which will unload the metaslabs and set ms->ms_group == NULL. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8602 Closes openzfs#9751
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 7, 2020
Any running 'zpool initialize' or TRIM must be cancelled prior to the vdev_metaslab_fini() call in spa_vdev_remove_log() which will unload the metaslabs and set ms->ms_group == NULL. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#8602 Closes openzfs#9751
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Any running 'zpool initialize' or TRIM must be cancelled prior to the vdev_metaslab_fini() call in spa_vdev_remove_log() which will unload the metaslabs and set ms->ms_group == NULL. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #8602 Closes #9751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolve #8602 which is one of the more common ztest failures
encountered by the CI.
Description
Any running
zpool initializeor TRIM must be cancelled priorto the
vdev_metaslab_fini()call in spa_vdev_remove_log() whichwill unload the metaslabs and set ms->ms_group == NULL.
How Has This Been Tested?
Unfortunately, I've been unable to consistently reproduce this
issue locally. I've run
ztestwith this PR applied for severalhours and was unable to reproduce the issue. However, since the
CI does relatively frequently hit this issue I've opened this PR for
additional testing and increased the ztest run time to 2 hours.
Types of changes
Checklist:
Signed-off-by.