Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Replace /var/tmp with $TEST_BASE_DIR #9775

Merged
merged 1 commit into from
Dec 28, 2019
Merged

ZTS: Replace /var/tmp with $TEST_BASE_DIR #9775

merged 1 commit into from
Dec 28, 2019

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Keep the ZTS test files restricted to the requested target directory.
Assuming /var/tmp always has a large amount of free space can
lead to CI failures. This is particularly true in the CI where the root
filesystem, and hense /var/tmp is not particularly large.

Description

Remove a few hardcoded instances of /var/tmp. This should use
the $TEST_BASE_DIR in order to allow the ZTS to be optionally
run in an alternate directory using zfs-tests.sh -d <path>.

How Has This Been Tested?

Locally reran the modified test cases to verify they work as intended.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
ZTS: Replace /var/tmp with $TEST_BASE_DIR
c6584eb 
Remove a few hardcoded instances of /var/tmp.  This should use
the $TEST_BASE_DIR in order to allow the ZTS to be optionally
run in an alternate directory using `zfs-tests.sh -d <path>`.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Dec 27, 2019
PrivatePuffin
PrivatePuffin approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please,, less hardcoded repeated paths and values all the way! :)
(besides the other issue's with doing it this way ;) )

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 27, 2019
@behlendorf behlendorf merged commit edb24be into openzfs:master Dec 28, 2019
@codecov
Copy link

codecov bot commented Dec 28, 2019 •
edited
Loading

Codecov Report

Merging #9775 into master will increase coverage by 13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9775      +/-   ##
==========================================
+ Coverage      67%      80%     +13%     
==========================================
  Files         303      385      +82     
  Lines      104240   121475   +17235     
==========================================
+ Hits        69658    96772   +27114     
+ Misses      34582    24703    -9879
Flag Coverage Δ
#kernel 80% <ø> (?)
#user 67% <ø> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c97f3...c6584eb. Read the comment docs.

tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 2, 2020
@behlendorf @tonyhutter
ZTS: Replace /var/tmp with $TEST_BASE_DIR
b5580d6 
Remove a few hardcoded instances of /var/tmp.  This should use
the $TEST_BASE_DIR in order to allow the ZTS to be optionally
run in an alternate directory using `zfs-tests.sh -d <path>`.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9775
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 7, 2020
@behlendorf @tonyhutter
ZTS: Replace /var/tmp with $TEST_BASE_DIR
2f3d42b 
Remove a few hardcoded instances of /var/tmp.  This should use
the $TEST_BASE_DIR in order to allow the ZTS to be optionally
run in an alternate directory using `zfs-tests.sh -d <path>`.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#9775
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@behlendorf @tonyhutter
ZTS: Replace /var/tmp with $TEST_BASE_DIR
70d2e93 
Remove a few hardcoded instances of /var/tmp.  This should use
the $TEST_BASE_DIR in order to allow the ZTS to be optionally
run in an alternate directory using `zfs-tests.sh -d <path>`.

Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #9775
@behlendorf behlendorf deleted the zts-var-tmp branch April 19, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@ikozhukhov ikozhukhov ikozhukhov approved these changes

@PrivatePuffin PrivatePuffin PrivatePuffin approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behlendorf @jwk404 @ikozhukhov @PrivatePuffin