Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1875, #3744, #3735, #2432: Add support for app bundles via Bazel, Proguard, and build flavors #3750

Merged
merged 26 commits into from
Sep 10, 2021

Commits on Sep 1, 2021

  1. Add support for AABs, build flavors, and proguard.

    There are a lot of details to cover here--see the PR for the complete
    context.
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    919ab2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c31b07b View commit details
    Browse the repository at this point in the history
  3. Lint & codeowner fixes.

    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ceb1179 View commit details
    Browse the repository at this point in the history
  4. Fix failures.

    - Add missing codeowner
    - Add support for configuring base branch reference
    - Update CI for dev/alpha AAB builds to use 'develop' since there's no
      origin configured by default in the workflows
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cbe5e76 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7945d5 View commit details
    Browse the repository at this point in the history
  6. Initial commit.

    This is needed to open a PR on GitHub. This commit is being made so that
    the PR can start off in a broken Actions state.
    
    This also initially disables most non-Bazel workflows to make workflow
    iteration faster and less impacting on other team members.
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    366ab4d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c38b95c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Introduce infrastructure for batching.

    This introduces a new mechanism for passing lists of tests to sharded
    test targets in CI, and hooks it up. No actual sharding is occurring
    yet. This led to some simplifications in the CI workflow since the
    script can be more dynamic in computing the full list of targets (which
    also works around a previous bug with instrumentation tests being run).
    Java proto lite also needed to be upgraded for the scripts to be able to
    use it.
    
    More testing/documentation needed as this functionality continues to
    expand.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    ac73dd6 View commit details
    Browse the repository at this point in the history
  2. Add bucketing strategy.

    This simply partitions bucketed groups of targets into chunks of 10 for
    each run. Only 3 buckets are currently retained to test sharding in CI
    before introducing full support.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    3aec233 View commit details
    Browse the repository at this point in the history
  3. Fix caching & stabilize builds.

    Fixes some caching bucket and output bugs. Also, introduces while loop &
    keep_going to introduce resilience against app test build failures (or
    just test failures in general).
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    650570b View commit details
    Browse the repository at this point in the history
  4. Increase sharding & add randomization.

    Also, enable other workflows.
    
    Note that CI shouldn't fully pass yet since some documentation and
    testing needs to be added yet, but this is meant to be a more realistic
    test of the CI environment before the PR is finished.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d66bb2c View commit details
    Browse the repository at this point in the history
  5. Improving partitionin & readability.

    Adds a human-readable prefix to make the shards look a bit nicer.
    
    Also, adds more fine-tuned partitioning to bucket & reduce shard counts
    to improve overall timing. Will need to be tested in CI.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    3969a6d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7b2a0d View commit details
    Browse the repository at this point in the history
  7. Fix script.

    A newly computed variable wasn't updated to be used in an earlier
    change.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d1da067 View commit details
    Browse the repository at this point in the history
  8. Fix broken tests & test configuration.

    Add docstrings for proto.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    fbb3838 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e9cb61b View commit details
    Browse the repository at this point in the history
  10. Merge branch 'add-bundles-proguard-build-flavors' of github.com:oppia…

    …/oppia-android into add-bundles-proguard-build-flavors
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    601ff0a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6c91da9 View commit details
    Browse the repository at this point in the history
  12. Try 10 max parallel actions instead.

    See
    #3757 (comment)
    for context.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    e3eb6f2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3ff775f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    62576a1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d4f4448 View commit details
    Browse the repository at this point in the history
  16. Fix mv command so it works on Linux & OSX.

    Neither 'mv -t' nor piping to mv work on OSX so we needed to find an
    alternative (in this case just trying to move everything). This actually
    works a bit better since it's doing a per-file move rather than
    accommodating for files that shouldn't be moved (which isn't an issue
    since the destination directory is different than the one containing the
    AAB file).
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    f2a412d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Configuration menu
    Copy the full SHA
    b4915d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    385ad6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7160477 View commit details
    Browse the repository at this point in the history