-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3728, #3817, #3810, part of #1607: Integrate automatic app string language selection support #3795
Fix #3728, #3817, #3810, part of #1607: Integrate automatic app string language selection support #3795
Commits on Sep 1, 2021
-
Add support for AABs, build flavors, and proguard.
There are a lot of details to cover here--see the PR for the complete context.
Configuration menu - View commit details
-
Copy full SHA for 919ab2b - Browse repository at this point
Copy the full SHA 919ab2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c31b07b - Browse repository at this point
Copy the full SHA c31b07bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ceb1179 - Browse repository at this point
Copy the full SHA ceb1179View commit details -
- Add missing codeowner - Add support for configuring base branch reference - Update CI for dev/alpha AAB builds to use 'develop' since there's no origin configured by default in the workflows
Configuration menu - View commit details
-
Copy full SHA for cbe5e76 - Browse repository at this point
Copy the full SHA cbe5e76View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7945d5 - Browse repository at this point
Copy the full SHA d7945d5View commit details -
This is needed to open a PR on GitHub. This commit is being made so that the PR can start off in a broken Actions state. This also initially disables most non-Bazel workflows to make workflow iteration faster and less impacting on other team members.
Configuration menu - View commit details
-
Copy full SHA for 366ab4d - Browse repository at this point
Copy the full SHA 366ab4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c38b95c - Browse repository at this point
Copy the full SHA c38b95cView commit details
Commits on Sep 2, 2021
-
Introduce infrastructure for batching.
This introduces a new mechanism for passing lists of tests to sharded test targets in CI, and hooks it up. No actual sharding is occurring yet. This led to some simplifications in the CI workflow since the script can be more dynamic in computing the full list of targets (which also works around a previous bug with instrumentation tests being run). Java proto lite also needed to be upgraded for the scripts to be able to use it. More testing/documentation needed as this functionality continues to expand.
Configuration menu - View commit details
-
Copy full SHA for ac73dd6 - Browse repository at this point
Copy the full SHA ac73dd6View commit details -
This simply partitions bucketed groups of targets into chunks of 10 for each run. Only 3 buckets are currently retained to test sharding in CI before introducing full support.
Configuration menu - View commit details
-
Copy full SHA for 3aec233 - Browse repository at this point
Copy the full SHA 3aec233View commit details -
Fix caching & stabilize builds.
Fixes some caching bucket and output bugs. Also, introduces while loop & keep_going to introduce resilience against app test build failures (or just test failures in general).
Configuration menu - View commit details
-
Copy full SHA for 650570b - Browse repository at this point
Copy the full SHA 650570bView commit details -
Increase sharding & add randomization.
Also, enable other workflows. Note that CI shouldn't fully pass yet since some documentation and testing needs to be added yet, but this is meant to be a more realistic test of the CI environment before the PR is finished.
Configuration menu - View commit details
-
Copy full SHA for d66bb2c - Browse repository at this point
Copy the full SHA d66bb2cView commit details -
Improving partitionin & readability.
Adds a human-readable prefix to make the shards look a bit nicer. Also, adds more fine-tuned partitioning to bucket & reduce shard counts to improve overall timing. Will need to be tested in CI.
Configuration menu - View commit details
-
Copy full SHA for 3969a6d - Browse repository at this point
Copy the full SHA 3969a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7b2a0d - Browse repository at this point
Copy the full SHA e7b2a0dView commit details -
A newly computed variable wasn't updated to be used in an earlier change.
Configuration menu - View commit details
-
Copy full SHA for d1da067 - Browse repository at this point
Copy the full SHA d1da067View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb3838 - Browse repository at this point
Copy the full SHA fbb3838View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9cb61b - Browse repository at this point
Copy the full SHA e9cb61bView commit details -
Merge branch 'add-bundles-proguard-build-flavors' of github.com:oppia…
…/oppia-android into add-bundles-proguard-build-flavors
Configuration menu - View commit details
-
Copy full SHA for 601ff0a - Browse repository at this point
Copy the full SHA 601ff0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c91da9 - Browse repository at this point
Copy the full SHA 6c91da9View commit details -
Try 10 max parallel actions instead.
See #3757 (comment) for context.
Configuration menu - View commit details
-
Copy full SHA for e3eb6f2 - Browse repository at this point
Copy the full SHA e3eb6f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ff775f - Browse repository at this point
Copy the full SHA 3ff775fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62576a1 - Browse repository at this point
Copy the full SHA 62576a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f4448 - Browse repository at this point
Copy the full SHA d4f4448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0644f70 - Browse repository at this point
Copy the full SHA 0644f70View commit details -
Fix mv command so it works on Linux & OSX.
Neither 'mv -t' nor piping to mv work on OSX so we needed to find an alternative (in this case just trying to move everything). This actually works a bit better since it's doing a per-file move rather than accommodating for files that shouldn't be moved (which isn't an issue since the destination directory is different than the one containing the AAB file).
Configuration menu - View commit details
-
Copy full SHA for f2a412d - Browse repository at this point
Copy the full SHA f2a412dView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa29739 - Browse repository at this point
Copy the full SHA aa29739View commit details
Commits on Sep 4, 2021
-
Introduce initial domain layer for translations.
Documentation, thorough tests, and detailed description of these changes are still needed.
Configuration menu - View commit details
-
Copy full SHA for c8248ca - Browse repository at this point
Copy the full SHA c8248caView commit details
Commits on Sep 8, 2021
-
Initial app layer implementation for translations.
This demonstrates working string selection for system-based and overwritten app languages, including necessary activity recreation & layout direction overwriting. This also includes a bunch of Dagger infra refactoring so that some app layer packages can now be modularized (including the new packages).
Configuration menu - View commit details
-
Copy full SHA for 512f0b3 - Browse repository at this point
Copy the full SHA 512f0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b8298d - Browse repository at this point
Copy the full SHA 6b8298dView commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor
Configuration menu - View commit details
-
Copy full SHA for 2aa4470 - Browse repository at this point
Copy the full SHA 2aa4470View commit details
Commits on Sep 10, 2021
-
This involves MANY broad changes to ensure consistent string retrieval (for arrays and plurals), formatting, and string transformations throughout the codebase. Some extra patterns to added to fix things that were needed, and a few issues were fixed along the way.
Configuration menu - View commit details
-
Copy full SHA for 014ac54 - Browse repository at this point
Copy the full SHA 014ac54View commit details -
Add needed domain changes for downstream branch.
Also includes fixing circular dependency issue by splitting out some of the locale components to be part of utility rather than domain (so that utiltiy and other packages can depend on MachineLocale).
Configuration menu - View commit details
-
Copy full SHA for 583a05c - Browse repository at this point
Copy the full SHA 583a05cView commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor
Configuration menu - View commit details
-
Copy full SHA for ceb66d9 - Browse repository at this point
Copy the full SHA ceb66d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4915d1 - Browse repository at this point
Copy the full SHA b4915d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385ad6a - Browse repository at this point
Copy the full SHA 385ad6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7160477 - Browse repository at this point
Copy the full SHA 7160477View commit details
Commits on Sep 14, 2021
-
Fix regex checks for translated strings.
Also, performance improvements for the regex check.
Configuration menu - View commit details
-
Copy full SHA for 3f92b84 - Browse repository at this point
Copy the full SHA 3f92b84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f31ed - Browse repository at this point
Copy the full SHA 96f31edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99130f0 - Browse repository at this point
Copy the full SHA 99130f0View commit details -
Merge commit '92ce46b81b2183283e04c4d592fc8682338e1404' into add-bund…
…les-proguard-build-flavors
Configuration menu - View commit details
-
Copy full SHA for b48cca6 - Browse repository at this point
Copy the full SHA b48cca6View commit details -
Merge branch 'add-bundles-proguard-build-flavors' into temp-branch-co…
…mbine-prework-and-translations
Configuration menu - View commit details
-
Copy full SHA for 3fcc1e5 - Browse repository at this point
Copy the full SHA 3fcc1e5View commit details -
Merge branch 'fix-regex-checks-for-translated-strings' into temp-bran…
…ch-combine-prework-and-translations
Configuration menu - View commit details
-
Copy full SHA for 060c37e - Browse repository at this point
Copy the full SHA 060c37eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d556fb - Browse repository at this point
Copy the full SHA 6d556fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a266ba - Browse repository at this point
Copy the full SHA 4a266baView commit details
Commits on Sep 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3746880 - Browse repository at this point
Copy the full SHA 3746880View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor
Configuration menu - View commit details
-
Copy full SHA for cb80423 - Browse repository at this point
Copy the full SHA cb80423View commit details -
Merge commit '2d47a87b9020b95355e86e96254b1ad68f3843b2' into fix-rege…
…x-checks-for-translated-strings
Configuration menu - View commit details
-
Copy full SHA for 1021a89 - Browse repository at this point
Copy the full SHA 1021a89View commit details -
Merge branch 'fix-regex-checks-for-translated-strings' into temp-bran…
…ch-combine-prework-and-translations
Configuration menu - View commit details
-
Copy full SHA for e58e422 - Browse repository at this point
Copy the full SHA e58e422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ad1f41 - Browse repository at this point
Copy the full SHA 2ad1f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0f8b45 - Browse repository at this point
Copy the full SHA c0f8b45View commit details -
Merge branch 'temp-branch-combine-prework-and-translations' into loca…
…lization-part4-introduce-controller-and-protos
Configuration menu - View commit details
-
Copy full SHA for 87f84a8 - Browse repository at this point
Copy the full SHA 87f84a8View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor Conflicts: scripts/assets/file_content_validation_checks.textproto scripts/src/java/org/oppia/android/scripts/regex/RegexPatternValidationCheck.kt
Configuration menu - View commit details
-
Copy full SHA for ebe2262 - Browse repository at this point
Copy the full SHA ebe2262View commit details -
Configuration menu - View commit details
-
Copy full SHA for f059838 - Browse repository at this point
Copy the full SHA f059838View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85e7574 - Browse repository at this point
Copy the full SHA 85e7574View commit details
Commits on Sep 16, 2021
-
Also, abstract ContentLocale for consistency & to disallow direct construction.
Configuration menu - View commit details
-
Copy full SHA for 7a9d952 - Browse repository at this point
Copy the full SHA 7a9d952View commit details
Commits on Sep 17, 2021
-
Add 6/11 test suites (& placeholders for other 4).
Silence one file missing a test suite (since it doesn't need one). Also, some tweaks to the language support definitions.
Configuration menu - View commit details
-
Copy full SHA for 4348fb1 - Browse repository at this point
Copy the full SHA 4348fb1View commit details
Commits on Sep 18, 2021
-
Add more test suites for domain layers.
Included introducing a new general purpose utility for testing data providers + its own test suite.
Configuration menu - View commit details
-
Copy full SHA for e8afb60 - Browse repository at this point
Copy the full SHA e8afb60View commit details
Commits on Sep 20, 2021
-
Introduce wrapper & fake for bidi wrapping.
Also, add test version of AssetRepository. Add new placeholder tests & update all tests project-wide to make sure that they build.
Configuration menu - View commit details
-
Copy full SHA for 08a8219 - Browse repository at this point
Copy the full SHA 08a8219View commit details -
Included some shadow refactoring, and introducing new test-only resources.
Configuration menu - View commit details
-
Copy full SHA for 0112762 - Browse repository at this point
Copy the full SHA 0112762View commit details
Commits on Sep 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2015e8e - Browse repository at this point
Copy the full SHA 2015e8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2acb592 - Browse repository at this point
Copy the full SHA 2acb592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0238557 - Browse repository at this point
Copy the full SHA 0238557View commit details -
Configuration menu - View commit details
-
Copy full SHA for 826545a - Browse repository at this point
Copy the full SHA 826545aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 703f770 - Browse repository at this point
Copy the full SHA 703f770View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor Conflicts: app/src/main/java/org/oppia/android/app/application/ApplicationComponent.kt scripts/assets/file_content_validation_checks.textproto utility/src/main/java/org/oppia/android/util/locale/OppiaLocale.kt
Configuration menu - View commit details
-
Copy full SHA for 2cc7c07 - Browse repository at this point
Copy the full SHA 2cc7c07View commit details -
Make all non-app layer targets build (haven't run tests yet). Audited existing bidi wrapping cases & converted strings over to being %s-only.
Configuration menu - View commit details
-
Copy full SHA for db3a3a8 - Browse repository at this point
Copy the full SHA db3a3a8View commit details -
Fix most test targets (builds).
All non-app tests confirmed as passing.
Configuration menu - View commit details
-
Copy full SHA for d667639 - Browse repository at this point
Copy the full SHA d667639View commit details
Commits on Sep 22, 2021
-
Fix all remaining test builds.
Introduce new TestActivity for scaffolding all non-activity tests.
Configuration menu - View commit details
-
Copy full SHA for 267c6d6 - Browse repository at this point
Copy the full SHA 267c6d6View commit details -
Add fixes for question player & old answer displaying. Add fix for guaranteed crash on startup after some changes between now & the first build of MR3 (dueu to extra updates in SplashActivityPresenter).
Configuration menu - View commit details
-
Copy full SHA for 670c5e8 - Browse repository at this point
Copy the full SHA 670c5e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cccd1b4 - Browse repository at this point
Copy the full SHA cccd1b4View commit details -
Type specifier pattern & fixes.
Address temporary TODO by removing kdoc.
Configuration menu - View commit details
-
Copy full SHA for ee88628 - Browse repository at this point
Copy the full SHA ee88628View commit details
Commits on Sep 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 07b7823 - Browse repository at this point
Copy the full SHA 07b7823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ad41f3 - Browse repository at this point
Copy the full SHA 8ad41f3View commit details -
Required an update to truth proto lite import (due to an incompatible update in the common Truth dep).
Configuration menu - View commit details
-
Copy full SHA for f876784 - Browse repository at this point
Copy the full SHA f876784View commit details
Commits on Sep 24, 2021
-
Other miscellaneous fixes needed to support new tests.
Configuration menu - View commit details
-
Copy full SHA for 180bd52 - Browse repository at this point
Copy the full SHA 180bd52View commit details -
1. Introduce proper API compatibility for LocaleController 2. Ensure TranslationController is scoped (breaks test in downstream PR)
Configuration menu - View commit details
-
Copy full SHA for e879c04 - Browse repository at this point
Copy the full SHA e879c04View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor
Configuration menu - View commit details
-
Copy full SHA for 326d5d9 - Browse repository at this point
Copy the full SHA 326d5d9View commit details
Commits on Sep 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 86a50b7 - Browse repository at this point
Copy the full SHA 86a50b7View commit details -
Resolve nearly all pending TODOs.
Only remainder is a test suite whose tests need to be migrated.
Configuration menu - View commit details
-
Copy full SHA for afb80e5 - Browse repository at this point
Copy the full SHA afb80e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 970d561 - Browse repository at this point
Copy the full SHA 970d561View commit details
Commits on Sep 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b7f63c3 - Browse repository at this point
Copy the full SHA b7f63c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a85c49 - Browse repository at this point
Copy the full SHA 3a85c49View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor Conflicts: app/src/main/res/values-pt-rBR/strings.xml
Configuration menu - View commit details
-
Copy full SHA for 0fa47f7 - Browse repository at this point
Copy the full SHA 0fa47f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74593a8 - Browse repository at this point
Copy the full SHA 74593a8View commit details
Commits on Sep 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 51fb398 - Browse repository at this point
Copy the full SHA 51fb398View commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor Conflicts: app/BUILD.bazel
Configuration menu - View commit details
-
Copy full SHA for e66c24d - Browse repository at this point
Copy the full SHA e66c24dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce9446f - Browse repository at this point
Copy the full SHA ce9446fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de427e - Browse repository at this point
Copy the full SHA 3de427eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d7cf31a - Browse repository at this point
Copy the full SHA d7cf31aView commit details -
Merge branch 'localization-part4-introduce-controller-and-protos' int…
…o localization-part5-introduce-app-string-translations-support-and-refactor
Configuration menu - View commit details
-
Copy full SHA for 37e852f - Browse repository at this point
Copy the full SHA 37e852fView commit details -
Configuration menu - View commit details
-
Copy full SHA for eec5a9f - Browse repository at this point
Copy the full SHA eec5a9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f47b6 - Browse repository at this point
Copy the full SHA 44f47b6View commit details -
Merge branch 'develop' into localization-part5-introduce-app-string-t…
…ranslations-support-and-refactor Conflicts: app/src/sharedTest/java/org/oppia/android/app/testing/ImageRegionSelectionInteractionViewTest.kt
Configuration menu - View commit details
-
Copy full SHA for 085fa41 - Browse repository at this point
Copy the full SHA 085fa41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2377ee5 - Browse repository at this point
Copy the full SHA 2377ee5View commit details