Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3728, #3817, #3810, part of #1607: Integrate automatic app string language selection support #3795

Commits on Sep 1, 2021

  1. Add support for AABs, build flavors, and proguard.

    There are a lot of details to cover here--see the PR for the complete
    context.
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    919ab2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c31b07b View commit details
    Browse the repository at this point in the history
  3. Lint & codeowner fixes.

    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ceb1179 View commit details
    Browse the repository at this point in the history
  4. Fix failures.

    - Add missing codeowner
    - Add support for configuring base branch reference
    - Update CI for dev/alpha AAB builds to use 'develop' since there's no
      origin configured by default in the workflows
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    cbe5e76 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7945d5 View commit details
    Browse the repository at this point in the history
  6. Initial commit.

    This is needed to open a PR on GitHub. This commit is being made so that
    the PR can start off in a broken Actions state.
    
    This also initially disables most non-Bazel workflows to make workflow
    iteration faster and less impacting on other team members.
    BenHenning committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    366ab4d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c38b95c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Introduce infrastructure for batching.

    This introduces a new mechanism for passing lists of tests to sharded
    test targets in CI, and hooks it up. No actual sharding is occurring
    yet. This led to some simplifications in the CI workflow since the
    script can be more dynamic in computing the full list of targets (which
    also works around a previous bug with instrumentation tests being run).
    Java proto lite also needed to be upgraded for the scripts to be able to
    use it.
    
    More testing/documentation needed as this functionality continues to
    expand.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    ac73dd6 View commit details
    Browse the repository at this point in the history
  2. Add bucketing strategy.

    This simply partitions bucketed groups of targets into chunks of 10 for
    each run. Only 3 buckets are currently retained to test sharding in CI
    before introducing full support.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    3aec233 View commit details
    Browse the repository at this point in the history
  3. Fix caching & stabilize builds.

    Fixes some caching bucket and output bugs. Also, introduces while loop &
    keep_going to introduce resilience against app test build failures (or
    just test failures in general).
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    650570b View commit details
    Browse the repository at this point in the history
  4. Increase sharding & add randomization.

    Also, enable other workflows.
    
    Note that CI shouldn't fully pass yet since some documentation and
    testing needs to be added yet, but this is meant to be a more realistic
    test of the CI environment before the PR is finished.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d66bb2c View commit details
    Browse the repository at this point in the history
  5. Improving partitionin & readability.

    Adds a human-readable prefix to make the shards look a bit nicer.
    
    Also, adds more fine-tuned partitioning to bucket & reduce shard counts
    to improve overall timing. Will need to be tested in CI.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    3969a6d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7b2a0d View commit details
    Browse the repository at this point in the history
  7. Fix script.

    A newly computed variable wasn't updated to be used in an earlier
    change.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d1da067 View commit details
    Browse the repository at this point in the history
  8. Fix broken tests & test configuration.

    Add docstrings for proto.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    fbb3838 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e9cb61b View commit details
    Browse the repository at this point in the history
  10. Merge branch 'add-bundles-proguard-build-flavors' of github.com:oppia…

    …/oppia-android into add-bundles-proguard-build-flavors
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    601ff0a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6c91da9 View commit details
    Browse the repository at this point in the history
  12. Try 10 max parallel actions instead.

    See
    #3757 (comment)
    for context.
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    e3eb6f2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3ff775f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    62576a1 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d4f4448 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0644f70 View commit details
    Browse the repository at this point in the history
  17. Fix mv command so it works on Linux & OSX.

    Neither 'mv -t' nor piping to mv work on OSX so we needed to find an
    alternative (in this case just trying to move everything). This actually
    works a bit better since it's doing a per-file move rather than
    accommodating for files that shouldn't be moved (which isn't an issue
    since the destination directory is different than the one containing the
    AAB file).
    BenHenning committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    f2a412d View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    aa29739 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2021

  1. Introduce initial domain layer for translations.

    Documentation, thorough tests, and detailed description of these changes
    are still needed.
    BenHenning committed Sep 4, 2021
    Configuration menu
    Copy the full SHA
    c8248ca View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Initial app layer implementation for translations.

    This demonstrates working string selection for system-based and
    overwritten app languages, including necessary activity recreation &
    layout direction overwriting.
    
    This also includes a bunch of Dagger infra refactoring so that some app
    layer packages can now be modularized (including the new packages).
    BenHenning committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    512f0b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b8298d View commit details
    Browse the repository at this point in the history
  3. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    BenHenning committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    2aa4470 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Add patterns & fixes.

    This involves MANY broad changes to ensure consistent string retrieval
    (for arrays and plurals), formatting, and string transformations
    throughout the codebase. Some extra patterns to added to fix things that
    were needed, and a few issues were fixed along the way.
    BenHenning committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    014ac54 View commit details
    Browse the repository at this point in the history
  2. Add needed domain changes for downstream branch.

    Also includes fixing circular dependency issue by splitting out some of
    the locale components to be part of utility rather than domain (so that
    utiltiy and other packages can depend on MachineLocale).
    BenHenning committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    583a05c View commit details
    Browse the repository at this point in the history
  3. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    BenHenning committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ceb66d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b4915d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    385ad6a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7160477 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Fix regex checks for translated strings.

    Also, performance improvements for the regex check.
    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3f92b84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96f31ed View commit details
    Browse the repository at this point in the history
  3. Lint-ish fix.

    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    99130f0 View commit details
    Browse the repository at this point in the history
  4. Merge commit '92ce46b81b2183283e04c4d592fc8682338e1404' into add-bund…

    …les-proguard-build-flavors
    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b48cca6 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'add-bundles-proguard-build-flavors' into temp-branch-co…

    …mbine-prework-and-translations
    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3fcc1e5 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'fix-regex-checks-for-translated-strings' into temp-bran…

    …ch-combine-prework-and-translations
    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    060c37e View commit details
    Browse the repository at this point in the history
  7. Fix failing regex checks.

    BenHenning committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    6d556fb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4a266ba View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Clean up locale infra.

    Add some other needed functionality.
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    3746880 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    cb80423 View commit details
    Browse the repository at this point in the history
  3. Merge commit '2d47a87b9020b95355e86e96254b1ad68f3843b2' into fix-rege…

    …x-checks-for-translated-strings
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    1021a89 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'fix-regex-checks-for-translated-strings' into temp-bran…

    …ch-combine-prework-and-translations
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    e58e422 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2ad1f41 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c0f8b45 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'temp-branch-combine-prework-and-translations' into loca…

    …lization-part4-introduce-controller-and-protos
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    87f84a8 View commit details
    Browse the repository at this point in the history
  8. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    
    Conflicts:
    	scripts/assets/file_content_validation_checks.textproto
    	scripts/src/java/org/oppia/android/scripts/regex/RegexPatternValidationCheck.kt
    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    ebe2262 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f059838 View commit details
    Browse the repository at this point in the history
  10. Fix broken tests.

    BenHenning committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    85e7574 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Fix lint issues & add KDocs.

    Also, abstract ContentLocale for consistency & to disallow direct
    construction.
    BenHenning committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    7a9d952 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Add 6/11 test suites (& placeholders for other 4).

    Silence one file missing a test suite (since it doesn't need one).
    
    Also, some tweaks to the language support definitions.
    BenHenning committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    4348fb1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Add more test suites for domain layers.

    Included introducing a new general purpose utility for testing data
    providers + its own test suite.
    BenHenning committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    e8afb60 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Introduce wrapper & fake for bidi wrapping.

    Also, add test version of AssetRepository.
    
    Add new placeholder tests & update all tests project-wide to make sure
    that they build.
    BenHenning committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    08a8219 View commit details
    Browse the repository at this point in the history
  2. Add remaining tests.

    Included some shadow refactoring, and introducing new test-only
    resources.
    BenHenning committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    0112762 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Fix Gradle builds.

    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2015e8e View commit details
    Browse the repository at this point in the history
  2. Lint fixes.

    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2acb592 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0238557 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    826545a View commit details
    Browse the repository at this point in the history
  5. Add new codeowners.

    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    703f770 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    
    Conflicts:
    	app/src/main/java/org/oppia/android/app/application/ApplicationComponent.kt
    	scripts/assets/file_content_validation_checks.textproto
    	utility/src/main/java/org/oppia/android/util/locale/OppiaLocale.kt
    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2cc7c07 View commit details
    Browse the repository at this point in the history
  7. Post-merge fixes.

    Make all non-app layer targets build (haven't run tests yet).
    
    Audited existing bidi wrapping cases & converted strings over to being
    %s-only.
    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    db3a3a8 View commit details
    Browse the repository at this point in the history
  8. Fix most test targets (builds).

    All non-app tests confirmed as passing.
    BenHenning committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    d667639 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Fix all remaining test builds.

    Introduce new TestActivity for scaffolding all non-activity tests.
    BenHenning committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    267c6d6 View commit details
    Browse the repository at this point in the history
  2. Fix all app layer tests.

    Add fixes for question player & old answer displaying.
    
    Add fix for guaranteed crash on startup after some changes between now &
    the first build of MR3 (dueu to extra updates in
    SplashActivityPresenter).
    BenHenning committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    670c5e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cccd1b4 View commit details
    Browse the repository at this point in the history
  4. Type specifier pattern & fixes.

    Address temporary TODO by removing kdoc.
    BenHenning committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    ee88628 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Add missing KDocs.

    BenHenning committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    07b7823 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ad41f3 View commit details
    Browse the repository at this point in the history
  3. Add new needed test dep.

    Required an update to truth proto lite import (due to an incompatible
    update in the common Truth dep).
    BenHenning committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    f876784 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Add needed testing coverage.

    Other miscellaneous fixes needed to support new tests.
    BenHenning committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    180bd52 View commit details
    Browse the repository at this point in the history
  2. Two fixes.

    1. Introduce proper API compatibility for LocaleController
    2. Ensure TranslationController is scoped (breaks test in downstream PR)
    BenHenning committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    e879c04 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    BenHenning committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    326d5d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Configuration menu
    Copy the full SHA
    86a50b7 View commit details
    Browse the repository at this point in the history
  2. Resolve nearly all pending TODOs.

    Only remainder is a test suite whose tests need to be migrated.
    BenHenning committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    afb80e5 View commit details
    Browse the repository at this point in the history
  3. Lint fixes.

    BenHenning committed Sep 25, 2021
    Configuration menu
    Copy the full SHA
    970d561 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Fix failures found on CI.

    BenHenning committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    b7f63c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a85c49 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    
    Conflicts:
    	app/src/main/res/values-pt-rBR/strings.xml
    BenHenning committed Sep 26, 2021
    Configuration menu
    Copy the full SHA
    0fa47f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    74593a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    51fb398 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    
    Conflicts:
    	app/BUILD.bazel
    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    e66c24d View commit details
    Browse the repository at this point in the history
  3. Post-merge fix.

    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    ce9446f View commit details
    Browse the repository at this point in the history
  4. Gradle Espresso test fix.

    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    3de427e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7cf31a View commit details
    Browse the repository at this point in the history
  6. Merge branch 'localization-part4-introduce-controller-and-protos' int…

    …o localization-part5-introduce-app-string-translations-support-and-refactor
    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    37e852f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eec5a9f View commit details
    Browse the repository at this point in the history
  8. Address reviewer comments.

    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    44f47b6 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'develop' into localization-part5-introduce-app-string-t…

    …ranslations-support-and-refactor
    
    Conflicts:
    	app/src/sharedTest/java/org/oppia/android/app/testing/ImageRegionSelectionInteractionViewTest.kt
    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    085fa41 View commit details
    Browse the repository at this point in the history
  10. Lint fixes.

    BenHenning committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    2377ee5 View commit details
    Browse the repository at this point in the history