Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MemoryTarget Implemented #13

Merged
merged 46 commits into from
Apr 28, 2023
Merged

feat: MemoryTarget Implemented #13

merged 46 commits into from
Apr 28, 2023

Conversation

sammychinedu2ky
Copy link
Member

@sammychinedu2ky sammychinedu2ky commented Apr 21, 2023 •
edited
Loading

fixes #4

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Apr 21, 2023 •
edited
Loading

The PR title should start with "feat:". And please use the keywords to reference an issue.

@sammychinedu2ky sammychinedu2ky changed the title Feat: MemoryTarget Implemented feat: MemoryTarget Implemented Apr 21, 2023
@sammychinedu2ky
Copy link
Member Author

The PR title should start with "feat:". And please use the keywords to reference an issue.

Ok thanks, I have fixed that

Wwwsylvia
Wwwsylvia requested changes Apr 21, 2023
View reviewed changes
Oras/Constants/DockerMediaTypes.cs Outdated Show resolved Hide resolved
Oras/Constants/DockerMediaTypes.cs Outdated Show resolved Hide resolved
Oras/Constants/DockerMediaTypes.cs Outdated Show resolved Hide resolved
Oras/Constants/OCISPECMediaTypes.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IFetcher.cs Show resolved Hide resolved
Oras/Interfaces/IFetcher.cs Show resolved Hide resolved
Oras/Models/Artifact.cs Outdated Show resolved Hide resolved
Oras/Models/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Models/MinimumDescriptor.cs Outdated Show resolved Hide resolved
Oras/Models/Descriptor.cs Show resolved Hide resolved
Wwwsylvia
Wwwsylvia requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are necessary

Oras/Constants/OCISPECMediaTypes.cs Outdated Show resolved Hide resolved
Oras/Content/Storage.cs Outdated Show resolved Hide resolved
Oras/Models/Descriptor.cs Outdated Show resolved Hide resolved
Oras/Content/Storage.cs Outdated Show resolved Hide resolved
Oras/Content/Storage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryTagResolver.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryTagResolver.cs Outdated Show resolved Hide resolved
@sammychinedu2ky
MemoryTarget Implemented
4268c94 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
e9c33ac 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
9ee246b 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
90a65ad 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
formatted solution
db6af80 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added support for memory target copy
d77fd42 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
changed variable name
602b82e 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
Revert "made some fixes"
6b0e037 
This reverts commit 5e99f87.

Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
reverted to memorytarget
b5a3678 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Wwwsylvia
Wwwsylvia requested changes Apr 25, 2023
View reviewed changes
Oras/Constants/OCIMediaTypes .cs Show resolved Hide resolved
Oras/Interfaces/IFetcher.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryTagResolver.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryTarget.cs Show resolved Hide resolved
@Wwwsylvia
Copy link
Member

Please add some basic unit tests at least for MemoryTarget to verify the code works as expected.

sammychinedu2ky and others added 10 commits April 25, 2023 05:07
@sammychinedu2ky @Wwwsylvia
Update Oras/Interfaces/IFetcher.cs
4699b29 
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky @Wwwsylvia
Update Oras/Interfaces/IReadOnlyStorage.cs
073d2f6 
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky @Wwwsylvia
Update Oras/Interfaces/IStorage.cs
c71fe35 
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky @Wwwsylvia
Update Oras/Memory/MemoryStorage.cs
593aa80 
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
fixing some naming issues
e98ecd3 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
Merge branch 'MemoryTarget' of https://github.com/sammychinedu2ky/ora…
b85f95a 
…s-dotnet into MemoryTarget
@sammychinedu2ky
made some fixes
2366a28 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
0851ae0 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added test and changed equality check of the MinimumDescriptor
5cad8c2 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added test
3edb84e 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Wwwsylvia
Wwwsylvia reviewed Apr 26, 2023
View reviewed changes
Test/OrasTest.csproj Outdated Show resolved Hide resolved
Oras/Memory/MemoryTarget.cs Outdated Show resolved Hide resolved
@sammychinedu2ky
changed variable name
ba1b896 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
formatted code
24d60be 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some changes
615981d 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some changes
c8dc204 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some changes
da63617 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some changes
fe4e31c 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some changes
b534c89 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Wwwsylvia
Wwwsylvia reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the access scopes of functions.

Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryStorage.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryTagResolver.cs Show resolved Hide resolved
Oras/Memory/MemoryTarget.cs Show resolved Hide resolved
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
.idea/.idea.Oras/.idea/.gitignore Outdated Show resolved Hide resolved
Oras.Tests/MemoryTest/MemoryTargetTest.cs Show resolved Hide resolved
@sammychinedu2ky
added predecessor method
e2f7137 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added predecessor method
3f63a8b 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added predecessor method
a4ac3d5 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added more test
64c868a 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added more test
c118c43 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Wwwsylvia
Wwwsylvia reviewed Apr 27, 2023
View reviewed changes
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Wwwsylvia
Wwwsylvia reviewed Apr 27, 2023
View reviewed changes
Oras/Content/GraphUtility.cs Outdated Show resolved Hide resolved
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IFetcher.cs Outdated Show resolved Hide resolved
Oras/Interfaces/IReadOnlyStorage.cs Outdated Show resolved Hide resolved
Oras.Tests/MemoryTest/MemoryTargetTest.cs Show resolved Hide resolved
Oras/Content/StorageUtility.cs Outdated Show resolved Hide resolved
@sammychinedu2ky
added more test
1687909 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
removed extra lines
7c83232 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made interfaces public
746bd2d 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
05e1c2f 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
made some fixes
52341bf 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
changed return type of predecessors
657d3eb 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added test for checking predecessors
7176d4e 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
added comment docs for predecessors test
c236642 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Wwwsylvia
Wwwsylvia reviewed Apr 28, 2023
View reviewed changes
Oras/Models/MinimumDescriptor.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
Oras/Memory/MemoryGraph.cs Outdated Show resolved Hide resolved
@sammychinedu2ky
made some fixes
75457a4 
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
Copy link
Member Author

Here is the Code Coverage Report of the Test taken
image

Wwwsylvia
Wwwsylvia approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 411011e into oras-project:main Apr 28, 2023
@sammychinedu2ky sammychinedu2ky deleted the MemoryTarget branch May 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Memory Target
2 participants
@sammychinedu2ky @Wwwsylvia