Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Copy #16

Merged
merged 11 commits into from
Apr 28, 2023
Merged

feat: Support Copy #16

merged 11 commits into from
Apr 28, 2023

Conversation

sammychinedu2ky
Copy link
Member

fixes #5

Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@Wwwsylvia
Copy link
Member

Wwwsylvia commented Apr 28, 2023

I think the PR title should be "support Copy" or something like that, as you are adding a feature, not just adding tests

Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Oras.Tests/CopyTest.cs Outdated Show resolved Hide resolved
@sammychinedu2ky sammychinedu2ky changed the title feat: Added test for Copy feat: Support Copy Apr 28, 2023
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
@sammychinedu2ky
Copy link
Member Author

Test Coverage Report
image

Signed-off-by: Samson Amaugo <sammychinedu2ky@gmail.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 7bb7651 into oras-project:main Apr 28, 2023
@sammychinedu2ky sammychinedu2ky deleted the mytargetcopy branch May 1, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Copy
2 participants