test: enable server-side config from context #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Jun 17, 2024
driver/config/test_config.go
Outdated
Comment on lines
83
to
86
| cID := r.Header.Get("Test-Config-Id") | ||
| if config, ok := t.configs[uuid.FromStringOrNil(cID)]; ok { | ||
| r = r.WithContext(WithConfigValues(r.Context(), config...)) | ||
| } |
There was a problem hiding this comment.
The handler looks up the config ID from the request header and adds the config to the request context server-side if it found it.
driver/config/test_config.go
Outdated
| } | ||
|
|
||
| func (t *ConfigurableTestHandler) UseConfigValues(r *http.Request, values ...map[string]any) *http.Request { | ||
| return t.UseConfig(r, t.RegisterConfig(values...)) |
There was a problem hiding this comment.
Registering the config values and setting the config header on the request (client side).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3954 +/- ##
==========================================
+ Coverage 78.18% 78.20% +0.02%
==========================================
Files 363 363
Lines 25443 25486 +43
==========================================
+ Hits 19892 19931 +39
- Misses 4030 4032 +2
- Partials 1521 1523 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can use the context-based test configs server side, e.g. in integration tests.