fix: emit SelfServiceMethodUsed in SettingsSucceeded event #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
reviewed
Aug 26, 2024
selfservice/flow/settings/hook.go
Outdated
| @@ -282,7 +282,8 @@ func (e *HookExecutor) PostSettingsHook(w http.ResponseWriter, r *http.Request, | |||
| WithField("flow_method", settingsType). | |||
| Debug("Completed all PostSettingsPrePersistHooks and PostSettingsPostPersistHooks.") | |||
|
|
|||
| trace.SpanFromContext(r.Context()).AddEvent(events.NewSettingsSucceeded(r.Context(), i.ID, string(ctxUpdate.Flow.Type), ctxUpdate.Flow.Active.String())) | |||
| trace.SpanFromContext(r.Context()).AddEvent(events.NewSettingsSucceeded( | |||
| r.Context(), i.ID, string(ctxUpdate.Flow.Type), ctxUpdate.Session.AMR)) | |||
There was a problem hiding this comment.
Isn't ctxUpdate.Session.AMR the method used to authenticate the session?
I would expect that field to contain "profile", "password", etc. depending on which group the user updated in the settings.
There was a problem hiding this comment.
Yes, it is the method used in the session. Should it be the group that got updated? Maybe that makes more sense, but it is not clear.
hperl
force-pushed
the
hperl/fix-SettingsSucceeded-SelfServiceMethodUsed
branch
from
3fb644d
to
99955fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
- Coverage 78.35% 78.34% -0.02%
==========================================
Files 370 370
Lines 26128 26129 +1
==========================================
- Hits 20473 20470 -3
- Misses 4094 4096 +2
- Partials 1561 1563 +2 ☔ View full report in Codecov by Sentry. |
aeneasr
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the SelfServiceMethodUsed attribute in the SettingsSucceeded event, which previously was always empty.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments