Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outline of event-based wind calculation. #124

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

joemoorhouse
Copy link
Collaborator

Makes (limited) use of numba for accelerating performance bottleneck.

Signed-off-by: Joe Moorhouse <joe.moorhouse@gmail.com>
@joemoorhouse
Copy link
Collaborator Author

Hi @ DomenicoLombardiGeoLab,
Here's a first outline of support for event-based calculations suitable for the wind model: see test_rotor_damage_event_based.

The idea is that you can complete WindTurbineModel in the test and then we can move into the models area. Not sure how clear the approach is from the comments, but please let me know in this chat. If you are happy with the outline we can merge into main.

By the way, I added support from sampling from a probability distribution that comprises probability bins, including lumped probabilities. This should fit your model where you define a probability for 0% loss and 100% loss (although I tried to make it general). I have used numba to accelerate the sampling, as this can become a bottleneck. This will JIT compile on first pass which takes a few seconds and will then cache the compiled code.

@joemoorhouse
Copy link
Collaborator Author

Hi @DomenicoLombardiGeoLab,
I'm writing this up in the methodology doc by the way...

Copy link

@DomenicoLombardiGeoLab DomenicoLombardiGeoLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

@DomenicoLombardiGeoLab
Copy link

Hi @joemoorhouse, before our next meeting I'd like to add two fragility functions to the prop_collapse method of the WindTurbineModel. Should I fork your repo with the new branch or wait that this is merged into main? hope above makes sense ;)

@joemoorhouse joemoorhouse merged commit 2461373 into os-climate:main Apr 12, 2023
@joemoorhouse joemoorhouse deleted the wind-events branch March 15, 2024 20:21
ModeSevenIndustrialSolutions pushed a commit that referenced this pull request Jun 17, 2024
Signed-off-by: Joe Moorhouse <joe.moorhouse@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants