Water temperature on-boarding #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rcp6p0 in the scenario list of core_hazards::cmip6_scenario_to_rcp Signed-off-by: EglantineGiraud <eglantine.giraud@gmail.com>
Fix get_hazard_data when the response is a list instead of float Signed-off-by: EglantineGiraud <eglantine.giraud@gmail.com>
ModeSevenIndustrialSolutions
pushed a commit
that referenced
this pull request
Jun 17, 2024
Water temperature on-boarding Add rcp6p0 in the scenario list of core_hazards::cmip6_scenario_to_rcp Fix get_hazard_data when the response is a list instead of float --------- Signed-off-by: EglantineGiraud <eglantine.giraud@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the water temperature hazard_data, i noticed that get_hazard_data does not work properly when the hazard response is a list (instead of float).