cmd: rename otk externals #922
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want some separate directory for this? |
|
Let's discuss in osbuild/otk#196 (comment) first how we want them to look like before doing this to avoid having to do it twice. Fwiw, a separate (sub)dir sounds nice indeed to make it easier to see that it belongs to otk. |
The `otk` externals are moved into a subdirectory of `cmd` and named by their target (they generate things for `osbuild`). Signed-off-by: Simon de Vlieger <supakeen@redhat.com>
supakeen
force-pushed
the
rename-otk-externals
branch
from
8c1d109
to
1cbd8da
Compare
|
The discussion in osbuild/otk#196 (comment) has been resolved by following the original idiom. I've updated this PR accordingly. Will need a PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Externals being used by
otkare going to try and follow a naming schema. This commit adjusts the current names to that schema.Needs PR in
otkas well.