Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add --libdir to override buildin libdir #185

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Sep 2, 2024

src: add --libdir to override buildin libdir

This allows the local developer to easily run local externals. Similar
to the experience with osbuild and given that otk developers will
most likely also run osbuild having the two similar is probably
a good thing.

[draft as the this is only very lightly tested (and not lint happy)]

@mvo5 mvo5 requested a review from supakeen September 2, 2024 10:11
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, my only concern here is adding the local developer case by default to the search path.

@mvo5

This comment was marked as outdated.

@supakeen
Copy link
Member

supakeen commented Sep 2, 2024

I'd support having a relative path but instead of magically inserting them have them behind a single argument flag like -d on the main command for dev?

@mvo5 mvo5 marked this pull request as draft September 6, 2024 15:10
@mvo5
Copy link
Contributor Author

mvo5 commented Sep 6, 2024

I'd support having a relative path but instead of magically inserting them have them behind a single argument flag like -d on the main command for dev?

I pushed a new version that adds --libdir in the spirit of osbuild, given that the two will often be used in parallel it's probably a good idea to keep them similar.

@supakeen
Copy link
Member

supakeen commented Sep 7, 2024

The type checker needs appeasement then we can get it in. --libdir is fine to me. There's no real reason to have _libdir + libdir() property as we aren't doing anything to it right but that's so minor.

(also let's undraft).

This allows the local developer to easily run local externals. Similar
to the experience with osbuild and given that otk developers will
most likely also run osbuild having the two similar is probably
a good thing.
@mvo5 mvo5 changed the title Makefile: add "make externals" to have a quick way forward src: add --libdir to override buildin libdir Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants