Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded advapi32 lib #1443

Closed
wants to merge 2 commits into from
Closed

Remove unneeded advapi32 lib #1443

wants to merge 2 commits into from

Commits on Dec 13, 2021

  1. Remove unneeded advapi32 lib 

    Used to be needed when Rust sometimes relied on RtlGenRandom instead of
BCryptGenRandom, but that changed as of
rust-lang/rust#84096

advapi32 is still used in Rust core, but only in the deprecated
`env::home_dir` API, which we don't use:

- https://github.com/rust-lang/rust/blob/22f8bde876f2fa9c5c4e95be1bce29cc271f2b51/library/std/src/sys/windows/c.rs#L681-L689
- https://github.com/rust-lang/rust/blob/22f8bde876f2fa9c5c4e95be1bce29cc271f2b51/library/std/src/sys/windows/os.rs#L292
- https://github.com/rust-lang/rust/blob/22f8bde876f2fa9c5c4e95be1bce29cc271f2b51/library/std/src/sys/windows/os.rs#L319
- https://github.com/rust-lang/rust/blob/22f8bde876f2fa9c5c4e95be1bce29cc271f2b51/library/std/src/env.rs#L566-L575
    @gj
    gj committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8aa8aa2 View commit details
    Browse the repository at this point in the history

  2. Test release build

    @gj
    gj committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3962e7d View commit details
    Browse the repository at this point in the history