Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verified_type #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add verified_type #94

wants to merge 1 commit into from

Conversation

yang3kc
Copy link
Member

@yang3kc yang3kc commented Jan 6, 2023

In case people are still using this package.

Will need to update the pypi version as well once merged.

@yang3kc yang3kc requested a review from mr-devs January 6, 2023 01:01
Copy link
Member

@mr-devs mr-devs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

I am assuming that the Twitter docs are out of date and that you've seen these in your experimentation but it seems like this is not listed in the official docs:

If you know this to work, then feel free to ignore the above and merge.

Thanks!

@igorbrigadir
Copy link

Yep, docs are lagging behind: https://twitter.com/suhemparack/status/1611085481395224576

  1. Tweet view count is available as impression_count under public_metrics
  2. source field is removed from the API
  3. verified_type is supported a user field to indicate account verification type (business, government, blue or none)

We ended up not removing source however, DocNow/twarc#682

Also, in case it's useful, i think the current version is also missing:

TweetFields: ['edit_history_tweet_ids', 'edit_controls']
MediaFields: ['alt_text', 'variants', 'url']

And List objects: https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/lists and Spaces https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/space (twarc is also missing spaces too but we haven't implemented those endpoints yet)

@mr-devs
Copy link
Member

mr-devs commented Jan 6, 2023

Thanks, @igorbrigadir — you are truly a legend... ❤️

@yangkcatiu I'll let you make the call about whether or not to add the additional optional fields as I suspect you may be working with the package a bit more actively than me.

@mr-devs mr-devs mentioned this pull request Jan 6, 2023
6 tasks
@mr-devs
Copy link
Member

mr-devs commented Jan 6, 2023

See #95 to track these regardless of whether they are all added or not.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants