[Insight] Usage of a function in loops should be avoided - in lib/LogParser.php, line 175

[ousamabenyounes]

in lib/LogParser.php, line 175

This loop uses a function. To avoid the overhead of executing the function n times, you should precalculate it before the loop.

        $file = $this->getSplFileObject();
        foreach ($hosts as $host) {
            $testConfiguration = $this->getTestConfiguration();
            $testConfiguration[$host] = (!isset($testConfiguration[$host]) ? [] : $testConfiguration[$host]);
            $this->setTestConfiguration($testConfiguration);
            for ($i = 0; $i < $this->getNumberOfLine(); $i++) {
                $line = $file->current();
                if ('' !== trim($line)) {
                    $this->parseOneLine($line);
                }
                $file->next();

---

Posted from SensioLabsInsight