Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support PHP 8.2 #1056

Closed
berti34 opened this issue Mar 23, 2023 · 6 comments
Closed

Please support PHP 8.2 #1056

berti34 opened this issue Mar 23, 2023 · 6 comments

Comments

@berti34
Copy link

berti34 commented Mar 23, 2023

Since NC 26 ist supporting PHP 8.2 the apps should do, too.
Currently I cannot install the very nice app because of PHP 8.2.
@socialize-IT
Copy link

If you do a manual install of the app and change the apps manifest to php 8.2 it seems to work. Tried that, but didn't test that much.

@berti34
Copy link
Author

berti34 commented Mar 24, 2023

"Message": "Class "OCP\AppFramework\Db\Mapper" not found",

No, that app is not working if I change the maximum PHP version from 8.1 to 8.2 in the file appinfo/info.xml

@JoshuaPettus
Copy link

Mapper being decommissioned by NC is a separate issue independent of php 8.2 #1050

paulijar added a commit that referenced this issue Mar 25, 2023
@paulijar
Claim support for PHP 8.2
d7659d0 
Didn't test this myself, but based on
https://www.php.net/manual/en/migration82.incompatible.php, there's no reason
to believe that this wouldn't work.

refs #1056
@amiga23
Copy link

amiga23 commented Mar 27, 2023

Also the nextcloud upgrade process stops with error when upgrading from 25 to 26 and music app was already installed.

Error: Class "OCP\AppFramework\Db\Mapper" not found

@amiga23
Copy link

amiga23 commented Mar 27, 2023

A PR that fixes the issue was already merged, waiting for release ...
#1055

@paulijar
Copy link
Collaborator

paulijar commented Apr 1, 2023

The support for PHP 8.2 (as well as for NC 26) has now been released in Music v1.8.2.

@paulijar paulijar closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@amiga23 @JoshuaPettus @paulijar @berti34 @socialize-IT