Stage OCI container images through GitHub Actions (GHA) to GitHub Container Registry (GHCR) / Provide OCI images for ARM64 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
May 20, 2023
Comment on lines
+92
to
+103
| - name: Log in to GHCR | ||
| uses: docker/login-action@v2 | ||
| with: | ||
| registry: ghcr.io | ||
| username: ${{ github.repository_owner }} | ||
| password: ${{ github.token }} | ||
|
|
||
| #- name: Log in to Docker Hub | ||
| # uses: docker/login-action@v2 | ||
| # with: | ||
| # username: ${{ secrets.DOCKER_USERNAME }} | ||
| # password: ${{ secrets.DOCKER_PASSWORD }} |
There was a problem hiding this comment.
You probably want to swap that after populating the secrets settings right, in order to keep publishing to the known location at Docker Hub.
Currently, the workflow publishes to GitHub Container Registry (GHCR), but it can be diverted to Docker Hub any time.
|
Hm. I see. What's special here is that it's a separate repository, and connects to the release of the Would you fancy a re-thinking of this architecture, by folding the contents of this repository into a Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if GH-66 is not strictly needed, as Docker Inc. will continue their FOSS offering, this patch would set the stage to do so without much ado.
Its main purpose, however, is to resolve GH-68, and start providing OCI images for ARMv7 and ARM64, other than AMD64. We are using this recipe on a few other repositories, including mqttwarn, and it works well.
As a benefit in comparison to the previous build system, this recipe will provide image variants for
latest,nightly, andpr-XXXbuilds.