make dependency on typify-macro optional #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the benefit of this? Are you seeing a significantly faster compilation of progenitor without the typify-macro dependency? |
|
Main benefit is reduced SBOM/SOUP(Software of Unknown Provenance). In automotive/medical/etc, every dependency needs to be recorded,audited,etc, so removing unused |
ahl
requested changes
Mar 9, 2023
typify/Cargo.toml
Outdated
| @@ -10,8 +10,11 @@ readme = "../README.md" | |||
| keywords = ["json", "schema", "proc_macro"] | |||
| categories = ["api-bindings", "compilers"] | |||
|
|
|||
| [features] | |||
| default = ["typify-macro"] | |||
jayvdb
force-pushed
the
make-macros-optional
branch
from
14622d6
to
223a3d0
Compare
jayvdb
changed the title
ahl
approved these changes
Mar 9, 2023
coreyja
added a commit
to coreyja/typify
that referenced
this pull request
Mar 11, 2023
* main: fix spelling (oxidecomputer#214) make dependency on typify-macro optional (oxidecomputer#213) Bump trybuild from 1.0.77 to 1.0.79 (oxidecomputer#209) Bump unicode-ident from 1.0.6 to 1.0.8 (oxidecomputer#208) Bump serde_json from 1.0.93 to 1.0.94 (oxidecomputer#210) Bump paste from 1.0.11 to 1.0.12 (oxidecomputer#211) Bump thiserror from 1.0.38 to 1.0.39 (oxidecomputer#212) Bump schemars from 0.8.11 to 0.8.12 (oxidecomputer#205) Bump syn from 1.0.107 to 1.0.109 (oxidecomputer#206)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. oxidecomputer/progenitor#345
happy to create a feature "macro" or "macros" if you prefer.